Review main Merged

35832[CLEANUP] Replace rednumber icons with TWBS

Benni Mack CR +2 V +2 Easy +37 −4 updated 01/06/15, 18:31

Commit message

The Constant Editor is using "rednumbers"
to highlight certain constants. This can be done
like this in the Constants

TSConstantEditor.content.3 = styles.content.links.extTarget

to add a red "3" (rendered as gif) inside
the constant editor to the option
"styles.content.links.extTarget".

The "rednumber icons" (1-20) are available in
three locations inside the core, and are now
replaced by inline HTML based on twbs.

The corresponding image files are
therefore removed.

Review

  • Code review CR +2
    • Stefan Froemken +2
    • Wouter Wolters +1
  • Verified V +2
    • Stefan Froemken +2
    • Wouter Wolters +1

Issues 1

Files 63

Show 43 more files

Review log 8

  1. Benni Mack uploaded patch set 1 01/06/15, 15:55

  2. Mathias Schreiber voted on patch set 1 CR +1 V +1 01/06/15, 15:58

  3. Benni Mack uploaded patch set 2 01/06/15, 15:59

  4. Mathias Schreiber voted on patch set 2 CR +1 V +1 01/06/15, 15:59

  5. Wouter Wolters uploaded patch set 3 01/06/15, 18:26

  6. Wouter Wolters voted on patch set 3 V +1 CR +1 01/06/15, 18:26

  7. Stefan Froemken voted on patch set 3 CR +2 V +2 01/06/15, 18:31

  8. Stefan Froemken merged patch set 3 01/06/15, 18:31