35836[BUGFIX] Avoid makeInstance calls starting with a backslash
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Issues 1
Files 2
Review log 10
-
Benni Mack uploaded patch set 1 01/06/15, 16:12
-
Markus Klein voted on patch set 1 CR +1 V +1 01/06/15, 16:33
-
Oliver Klee commented on patch set 1 01/06/15, 18:01
Can we have the unit test from master as well? -
Wouter Wolters voted on patch set 1 V +2 CR +2 01/06/15, 18:07
-
Wouter Wolters commented on patch set 1 01/06/15, 18:07
@oliver the master unit-test test for an exception, we do not throw that exception here;) -
Benni Mack merged patch set 1 01/06/15, 18:33
-
Mathias Brodala commented on patch set 2 01/07/15, 08:31
I cannot even begin to state that this is change is really bad. For 6.2 one should not include such a breaking change since it's in maintenance mode. And why not [!!!] like in master? And why no .rst? Apropos master: I was under the impression that any extension running with 7.0 would be able to run with any 7.x. This is not true anymore here; an extension using this is compatible with 7.0 and 7.1 but not with 7.2. If I understand the development/release process of 7.x correctly than this should at most trigger a deprecation warning and only throw an exception with 8.x. -
Oliver Klee commented on patch set 2 01/07/15, 08:53
Matthias, if I understand it correctly, for 6.2, all code that worked before still works, and some code that did not work now does. (The commit message for 6.2 is misleading because the 6.2 version does not throw an exception.) -
Wouter Wolters commented on patch set 2 01/07/15, 08:58
Indeed nothing broken here! No rst file because 6.2 doesn't contain any rst file. This is introduced since the start of TYPO3 CMS 7. I agree that the commit message is misleading. That should have been rewritten. -
Mathias Brodala commented on patch set 2 01/07/15, 08:59
My bad for not checking the actual change for 6.2.