Review TYPO3_6-2 Merged

35856[DB][BUGFIX] Change DB field sys_filemounts.base from tinyint to integer

Markus Klein CR +2 V +2 Easy +1 −1 updated 01/08/15, 14:15

Commit message

sys_filemounts.base holds a reference to a storage, which should
be of DB type "int" as the storage uid is an integer itself as well.

It was a tinyint(4) type and is changed now to int(11).

Review

  • Code review CR +2
    • Markus Klein +2
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 8

  1. Benni Mack commented on patch set 1 CR +1 01/06/15, 23:35

    wasn't this a 1:1 cherry-pick?
  2. Markus Klein commented on patch set 1 01/07/15, 00:54

    It was, just to double check for the DB change!
  3. Oliver Klee voted on patch set 1 CR +1 01/07/15, 09:05

  4. Michael Oehlhof voted on patch set 1 CR +1 01/08/15, 00:08

  5. Markus Klein updated the commit message in patch set 2 01/08/15, 02:03

  6. Christian Kuhn voted on patch set 2 CR +1 01/08/15, 13:57

  7. Markus Klein commented on patch set 2 CR +2 V +2 01/08/15, 14:15

    backport should be fine
  8. Markus Klein merged patch set 2 01/08/15, 14:15