35886[BUGFIX] Do not load jQuery twice
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 7
- typo3/sysext/beuser/Resources/Private/Layouts/Permission.html+1 −2
- typo3/sysext/core/Documentation/Changelog/master/Feature-63913-AllowRequireJsModulesForContainerViewHelper.rst+1 −1
- typo3/sysext/documentation/Resources/Private/Layouts/Default.html+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Layouts/Main.html+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/ContainerViewHelper.php+2 −6
- typo3/sysext/lang/Resources/Private/Layouts/Default.html+0 −1
- typo3/sysext/viewpage/Resources/Private/Layouts/DocHeader.html+1 −2
Review log 7
-
Markus Klein uploaded patch set 1 01/08/15, 01:47
-
Markus Klein updated the commit message in patch set 2 01/08/15, 01:52
-
Wouter Wolters commented on patch set 2 01/08/15, 08:04
when we merged the other patch I'm sure jQuery was not loaded twice. But this seems more a quick and dirty solution to me. loading jQuery is done in the pagerenderer with setting a property to TRUE.. so some weird stuff is going on there. -
Benni Mack commented on patch set 2 01/08/15, 08:45
Isn't this breaking because you remove a property from a viewhelper? Apart from that: This is great! -
Markus Klein commented on patch set 2 01/08/15, 09:47
@wouter: The reason is that BackendController loads jquery in the constructor! @benni: I think additional attributes do not harm, do they? -
Andreas Kienast commented on patch set 2 V -1 01/08/15, 10:16
Unfortunately, this patch breaks the EM. -
Markus Klein abandoned the change 01/08/15, 10:38
Language module is not fixed with this either