Review main Abandoned

35886[BUGFIX] Do not load jQuery twice

Markus Klein CR 0 V 0 Easy +7 −14 updated 01/08/15, 10:38

Commit message

jQuery is always loaded in BE now. Do not load it again.
Followup to https://review.typo3.org/34455

Review

  • Code review CR 0
  • Verified V 0

Files 7

Review log 7

  1. Markus Klein uploaded patch set 1 01/08/15, 01:47

  2. Markus Klein updated the commit message in patch set 2 01/08/15, 01:52

  3. Wouter Wolters commented on patch set 2 01/08/15, 08:04

    when we merged the other patch I'm sure jQuery was not loaded twice. But this seems more a quick and dirty solution to me. loading jQuery is done in the pagerenderer with setting a property to TRUE.. so some weird stuff is going on there.
  4. Benni Mack commented on patch set 2 01/08/15, 08:45

    Isn't this breaking because you remove a property from a viewhelper? Apart from that: This is great!
  5. Markus Klein commented on patch set 2 01/08/15, 09:47

    @wouter: The reason is that BackendController loads jquery in the constructor! @benni: I think additional attributes do not harm, do they?
  6. Andreas Kienast commented on patch set 2 V -1 01/08/15, 10:16

    Unfortunately, this patch breaks the EM.
  7. Markus Klein abandoned the change 01/08/15, 10:38

    Language module is not fixed with this either