35887[BUGFIX] Re-enable export of multiple records via clipboard
Commit message
Review
-
Code review CR +2
- Morton Jonuschat +2
- Daniel Goerz +1
-
Verified V +2
- Morton Jonuschat +2
- Daniel Goerz +1
Issues 1
Files 2
Review log 19
-
Georg Ringer uploaded patch set 1 01/08/15, 08:46
-
Helmut Hummel commented on patch set 1 01/08/15, 09:16
Clipboard.php:698should be changed to $params['tx_impexp'][(is_dir($v) ? 'dir' : 'file'][] = $v;Clipboard.php:704should be changed to $params['tx_impexp']['record'][] = $table . ':' . $uid;ImportExportController.php:574is this a related fix? -
Georg Ringer commented on patch set 1 01/08/15, 10:26
the array check is not needed to fix this regression but otherwise you will get an exception if you have a record ID in the url which does not exist anymore. it makes also sense to backport that as well. -
Markus Klein uploaded patch set 2 01/08/15, 10:45
-
Markus Klein voted on patch set 2 CR +1 01/08/15, 10:45
-
Andreas Kienast voted on patch set 2 CR +1 01/08/15, 13:41
-
Helmut Hummel commented on patch set 2 01/08/15, 17:28
ImportExportController.php:578the additional hsc is (unfortunately) wrong here. BackendUtility::getRecordTitle() may return HTML otoh the value of BackendUtility::getRecordTitle() is hsced many times in the core already :-/ hmm... -
Markus Klein commented on patch set 2 CR -1 01/08/15, 17:39
ImportExportController.php:578Replyoh can it? didn't know that. that's of course not good then. Have to check where the hsc happens then. Not because of XSS, but more because of broken HTML because an & is not so unlikely to be part of a record title -
Benni Mack commented on patch set 2 06/29/15, 19:53
@Markus: Could you continue tackling this patch? -
Markus Klein commented on patch set 2 06/29/15, 21:56
ImportExportController.php:578ReplyThe third parameter explains it. If that is TRUE the output is correctly hsc'd and is HTML. Will push followup -
Markus Klein uploaded patch set 3 06/29/15, 21:57
-
Markus Klein voted on patch set 3 CR +1 06/29/15, 21:57
-
Markus Klein voted on patch set 3 V +1 06/29/15, 22:17
-
Markus Klein commented on patch set 3 V -1 CR 0 06/29/15, 22:19
still only the last record is exported... -
TYPO3 Bot commented on patch set 3 07/05/15, 20:58
Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/204 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/68884592 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/69650763 -
Daniel Goerz uploaded patch set 4 10/09/15, 11:21
-
Daniel Goerz voted on patch set 4 CR +1 V +1 10/09/15, 11:27
-
Morton Jonuschat voted on patch set 4 CR +2 V +2 10/09/15, 12:03
-
Morton Jonuschat merged patch set 4 10/09/15, 12:07
Clipboard.php:689