Review main Merged

35887[BUGFIX] Re-enable export of multiple records via clipboard

Georg Ringer CR +2 V +2 Easy +11 −9 updated 10/09/15, 12:07

Commit message

The change of #57873 introduced a regression which doesn't allow
the export of multiple records via the clipboard module anymore.

The wrong parameter generation is fixed with this patch.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Daniel Goerz +1
  • Verified V +2
    • Morton Jonuschat +2
    • Daniel Goerz +1

Issues 1

Files 2

Review log 19

  1. Georg Ringer uploaded patch set 1 01/08/15, 08:46

  2. Helmut Hummel commented on patch set 1 01/08/15, 09:16

    Clipboard.php:689

    should be changed to $params['tx_impexp']['action'] = 'export'

    Clipboard.php:698

    should be changed to $params['tx_impexp'][(is_dir($v) ? 'dir' : 'file'][] = $v;

    Clipboard.php:704

    should be changed to $params['tx_impexp']['record'][] = $table . ':' . $uid;

    ImportExportController.php:574

    is this a related fix?
  3. Georg Ringer commented on patch set 1 01/08/15, 10:26

    the array check is not needed to fix this regression but otherwise you will get an exception if you have a record ID in the url which does not exist anymore. it makes also sense to backport that as well.
  4. Markus Klein uploaded patch set 2 01/08/15, 10:45

  5. Markus Klein voted on patch set 2 CR +1 01/08/15, 10:45

  6. Andreas Kienast voted on patch set 2 CR +1 01/08/15, 13:41

  7. Helmut Hummel commented on patch set 2 01/08/15, 17:28

    ImportExportController.php:578

    the additional hsc is (unfortunately) wrong here. BackendUtility::getRecordTitle() may return HTML otoh the value of BackendUtility::getRecordTitle() is hsced many times in the core already :-/ hmm...
  8. Markus Klein commented on patch set 2 CR -1 01/08/15, 17:39

    ImportExportController.php:578 Reply

    oh can it? didn't know that. that's of course not good then. Have to check where the hsc happens then. Not because of XSS, but more because of broken HTML because an & is not so unlikely to be part of a record title
  9. Benni Mack commented on patch set 2 06/29/15, 19:53

    @Markus: Could you continue tackling this patch?
  10. Markus Klein commented on patch set 2 06/29/15, 21:56

    ImportExportController.php:578 Reply

    The third parameter explains it. If that is TRUE the output is correctly hsc'd and is HTML. Will push followup
  11. Markus Klein uploaded patch set 3 06/29/15, 21:57

  12. Markus Klein voted on patch set 3 CR +1 06/29/15, 21:57

  13. Markus Klein voted on patch set 3 V +1 06/29/15, 22:17

  14. Markus Klein commented on patch set 3 V -1 CR 0 06/29/15, 22:19

    still only the last record is exported...
  15. TYPO3 Bot commented on patch set 3 07/05/15, 20:58

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/204 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/68884592 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/69650763
  16. Daniel Goerz uploaded patch set 4 10/09/15, 11:21

  17. Daniel Goerz voted on patch set 4 CR +1 V +1 10/09/15, 11:27

  18. Morton Jonuschat voted on patch set 4 CR +2 V +2 10/09/15, 12:03

  19. Morton Jonuschat merged patch set 4 10/09/15, 12:07