Review main Merged

35902[TASK] Clean up images for tt_content.imageorient

Benni Mack CR +2 V +2 Easy +10 −10 updated 01/08/15, 22:00

Commit message

Remove the old imageorientation images
from typo3/gfx/ and take the
images from t3skin and move them
to EXT:frontend.

Also, use EXT: paths to the images
instead of relative ones.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1

Issues 1

Files 21

Show 1 more file

Review log 9

  1. Benni Mack uploaded patch set 1 01/08/15, 13:52

  2. Benni Mack commented on patch set 1 01/08/15, 13:56

    make sure to clear all cache / configuration cache for testing.
  3. Andreas Kienast voted on patch set 1 CR +1 V +1 01/08/15, 14:01

  4. Markus Klein commented on patch set 1 01/08/15, 14:18

    why to frontend? Isn't this much more related to backend?
  5. Benni Mack commented on patch set 1 01/08/15, 19:18

    because the frontend extension provides the TCA definition and the columns, not the backend.
  6. Markus Klein commented on patch set 1 CR +1 01/08/15, 20:46

    Muh... of course. Feels wrong somehow, but is right.
  7. Benni Mack commented on patch set 1 01/08/15, 20:47

    yeah, I know. the wording. I think the long-term plans are to move this field (incl. the images ;)) to css styled content anyway, so this is just a cleaning up beforehand.
  8. Wouter Wolters voted on patch set 1 V +2 CR +2 01/08/15, 22:00

  9. Wouter Wolters merged patch set 1 01/08/15, 22:00