Review TYPO3_6-2 Abandoned

35903[BUGFIX] Allow page.config.pageTitleSeparator

Benni Mack CR 0 V 0 Easy +28 −19 updated 01/08/15, 19:50

Commit message

The TypoScript option page.config.pageTitleSeparator
does not work currently, however the unspecific option
config.pageTitleSeparator does work.

This is due to the fact that the PageGenerator class
is preparing all options with TSFE->config and the
TemplateService class is putting everything together
with tmpl->setup which is not the consolidated config
data for this page. In order to streamline the code,
the pageTitleSeparator logic is moved
to PageGenerator where TSFE->config is used instead.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 3

  1. Benni Mack uploaded patch set 1 01/08/15, 14:22

  2. Stefan Froemken voted on patch set 1 CR +1 V +1 01/08/15, 16:40

  3. Benni Mack abandoned the change 01/08/15, 19:50

    no 6.2 fixing for that one,sry . changes the logic within a public API.