35910[BUGFIX] Properly check TS conditions with key '0'
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Tymoteusz Motylewski +1
- Christian Futterlieb +1
-
Verified V +2
- Markus Klein +2
- Tymoteusz Motylewski +1
Issues 1
Files 2
Review log 15
-
Christian Futterlieb uploaded patch set 1 01/08/15, 18:33
-
Christian Futterlieb commented on patch set 1 01/08/15, 18:37
Where should the unit test go? I'm not sure, because the tests in sysext frontend seem to group all the condition testing.. -
Stefan Froemken commented on patch set 1 01/08/15, 18:42
AbstractConditionMatcher.php:531I think it is not necessary to have a binary safe check against an empty value. trim($splitAgain[1]) !== '' should be enough. -
Stefan Froemken commented on patch set 1 01/08/15, 18:51
In frontend/Tests/Unit/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php you will find some methods starting with "globalVar*". Add a new test there or, if it matches, add a new line to one of the existing tests. -
Markus Klein commented on patch set 1 01/08/15, 20:03
Properly check TS conditions with key '0'Please describe what you're changing, not what is not working.AbstractConditionMatcher.php:531Replystrcmp is too slow for a simple comparison against ''. Please go for !== -
Christian Futterlieb uploaded patch set 2 01/08/15, 22:15
-
Christian Futterlieb commented on patch set 1 01/08/15, 22:17
@Stefan: thanks for the advice, I added the unit test. @Markus: I'm sorry, my english is not very good :( please take a look at the commit message now -
Christian Futterlieb uploaded patch set 3 01/08/15, 22:19
-
Markus Klein updated the commit message in patch set 4 01/08/15, 23:58
-
Markus Klein commented on patch set 4 CR +1 01/08/15, 23:59
It's not about the language skills, it's just about what we describe. Just extended your message a bit. Thanks -
Christian Futterlieb commented on patch set 4 CR +1 01/09/15, 09:26
> Just extended your message a bit. Thanks :) -
Tymoteusz Motylewski voted on patch set 4 CR +1 V +1 01/10/15, 21:05
-
Markus Klein voted on patch set 4 V +2 CR +2 01/10/15, 21:51
-
Markus Klein merged patch set 4 01/10/15, 21:51
-
Markus Klein commented on patch set 5 01/10/15, 21:51
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit fee09ee2761456374f864bc3f477087fc8cf21f7