Review main Merged Breaking

35939[!!!][TASK] Remove option $TYPO3_CONF_VARS[BE][accessListRenderMode]

Benni Mack CR +2 V +2 Normal +53 −13 updated 01/10/15, 11:56

Commit message

With the recent overhaul to optimize the selection
of access lists (permissions) in BE user / BE groups
via checkbox,
the option $TYPO3_CONF_VARS[BE][accessListRenderMode]
which was set to "checkbox" already, can be removed
as it only serves as a shorthand function
to override TCA settings for be_users and be_groups.

In the front of having strong defaults and a simpler
option list, the option is removed and all values
within be_users/be_groups are set to
renderMode=checkbox directly.

Review

  • Code review CR +2
    • Markus Klein +2
    • Mathias Schreiber +1
  • Verified V +2
    • Markus Klein +2
    • Mathias Schreiber +1

Issues 1

Files 6

Review log 9

  1. Benni Mack uploaded patch set 1 01/09/15, 21:24

  2. Wouter Wolters updated the commit message in patch set 2 01/09/15, 22:10

  3. Markus Klein commented on patch set 2 01/09/15, 23:58

    Breaking-64226-OptionAccessListRenderModeRemoved.rst:35

    $GLOBALS

    SilentConfigurationUpgradeService.php:71

    Ticket number
  4. Markus Klein commented on patch set 2 CR -1 01/09/15, 23:59

    you forgot one in workspaces
  5. Markus Klein uploaded patch set 3 01/10/15, 00:00

  6. Markus Klein voted on patch set 3 CR +1 V +1 01/10/15, 00:01

  7. Mathias Schreiber voted on patch set 3 CR +1 V +1 01/10/15, 08:35

  8. Markus Klein voted on patch set 3 CR +2 V +2 01/10/15, 11:56

  9. Markus Klein merged patch set 3 01/10/15, 11:56