35940[TASK] Remove old PHP version leftovers
Commit message
Review
-
Code review CR +2
- Steffen Müller +2
- Anja Leichsenring +1
- Jan Helke +1
-
Verified V +2
- Steffen Müller +2
- Anja Leichsenring +1
- Jan Helke +1
Issues 1
Files 6
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+1 −6
- typo3/sysext/core/Classes/Utility/GeneralUtility.php5+0 −1
- typo3/sysext/core/Classes/Utility/OpcodeCacheUtility.php2+0 −14
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php5binary
- typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectConverter.php2+0 −20
- typo3/sysext/fluid/Classes/Core/Parser/TemplateParser.php+1 −3
Review log 23
-
Markus Klein uploaded patch set 1 01/09/15, 21:44
-
Markus Klein commented on patch set 1 01/09/15, 21:45
@Jigal, @Nicole: can you please run the unit tests on windows to see if this works now? -
Frederic Gaus commented on patch set 1 01/10/15, 08:07
GeneralUtility.php:2143When I understand correctly, this line as well as the usage of $vLen in the next line should be removed too.GeneralUtility.php:2145strcspn($v, $binaryChars) != strlen($v) -
Markus Klein commented on patch set 1 01/10/15, 08:15
GeneralUtility.php:2143ReplyWell, I considered this, but actually it speeds up things to check the length first. We need to calculate the strlen() anyway so it does not hurt to check $vLen in the if. -
Oliver Klee commented on patch set 1 01/10/15, 17:12
GeneralUtilityTest.php:915The comments can be removed, too, I think. -
Benni Mack commented on patch set 1 01/10/15, 19:59
also check for safe_mode please, not available anymore.GeneralUtilityTest.php:915do you want to change the comment as well? -
Markus Klein commented on patch set 1 01/10/15, 20:16
GeneralUtilityTest.php:915ReplyThe comments stay as long as this is WIP. This will stay WIP until somebody confirms the tests running on Windows! -
Stephan Großberndt commented on patch set 1 01/11/15, 12:55
Unit tests on current master fatal because of missing function strptime (see https://review.typo3.org/#/c/35530/) If I comment out the strptime-line with the wip-patch I get one error less: 3) TYPO3\CMS\Core\Tests\Unit\Utility\GeneralUtilityTest::copyDirectoryCopiesFilesAndDirectoriesWithRelativePaths RuntimeException: tearDown() cleanup: File, link or directory does not exist and one failure more: 10) TYPO3\CMS\Form\Tests\Unit\PostProcess\PostProcessorTest::processFindsClassSpecifiedByTypoScriptWithFormPrefix Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'processedWithPrefix' +'processedWithPrefixprocessedWithPrefix' -
Markus Klein commented on patch set 1 01/11/15, 23:05
@Stephan: This seems no to be related to this patch set -
Mathias Schreiber voted on patch set 1 CR +1 V +1 01/17/15, 19:48
-
Markus Klein commented on patch set 1 01/17/15, 21:01
@Nicole: ping, please run the tests. -
Oliver Klee commented on patch set 1 01/18/15, 11:13
Is this still WIP? -
Markus Klein updated the commit message in patch set 2 01/18/15, 13:23
-
Mathias Brodala commented on patch set 2 CR -1 01/20/15, 14:17
GeneralUtility.php:2144How about dropping this variable as it apparently was only used for PHP 5.2?OpcodeCacheUtility.php:115Is this method not used anywhere?GeneralUtilityTest.php:915Remove this comment and all following occurrences.ObjectConverter.php:233Is this method not used anywhere? -
Markus Klein commented on patch set 2 01/20/15, 22:39
GeneralUtility.php:2144ReplyWhat's the benefit? We don't need to run strcspn() if $v is empty.OpcodeCacheUtility.php:115ReplyNo. This is not used anywhere anymore. It can be removed as this is an internal utility class only.GeneralUtilityTest.php:915ReplyWill be done, once we got all the tests running on windows. I will cleanup this area then.ObjectConverter.php:233Replyfound no usages. removing it since it is protected -
Nicole Hummel commented on patch set 2 V +1 01/30/15, 19:48
Unit tests on Windows are passing -
Markus Klein commented on patch set 2 01/31/15, 08:55
Thanks a lot Nicole!! Will get this one ready now -
Markus Klein uploaded patch set 3 01/31/15, 09:01
-
Anja Leichsenring voted on patch set 3 CR +1 V +1 01/31/15, 09:12
-
Jan Helke voted on patch set 3 CR +1 V +1 01/31/15, 09:42
-
Steffen Müller commented on patch set 3 CR -1 01/31/15, 09:45
reviewing atm. -
Steffen Müller voted on patch set 3 CR +2 V +2 01/31/15, 09:46
-
Steffen Müller merged patch set 3 01/31/15, 09:47