35953[TASK] Improve Layout of CType Menu in page module
Commit message
Review
-
Code review CR +2
- Mathias Schreiber +2
- Philipp Gampe +1
-
Verified V +2
- Mathias Schreiber +2
- Philipp Gampe +1
Files 1
Review log 27
Show 2 earlier messages
-
Mathias Schreiber uploaded patch set 3 01/11/15, 16:44
-
Frans Saris commented on patch set 3 01/11/15, 17:39
-
Frans Saris commented on patch set 3 V -1 01/11/15, 17:55
PageLayoutView.php:1526There are menu types were no page selection is needed, so no pages are selectedPageLayoutView.php:1530You need to find the correct array value where $GLOBALS['TCA']['tt_content']['columns']['menu_type']['config']['items'][?][1] = $row['menu_type'] The array key isn't the value to check but array value 1 -
Daniel Maier commented on patch set 3 01/11/15, 19:04
PageLayoutView.php:1530ReplyI think you could use BackendUtility::getLabelFromItemList to get the correct menu type here. Tested with that and it works for me: $selectedMenuType = BackendUtility::getLabelFromItemlist('tt_content','menu_type',$row['menu_type']); -
Mathias Schreiber uploaded patch set 4 01/11/15, 19:04
-
Daniel Maier commented on patch set 4 01/11/15, 19:19
PageLayoutView.php:1684As also used for categories now, $pageUidList doesn't fit any more. Perhaps you could take sth that reflects both pageUid and CategoryUid, or sth more general... -
Daniel Maier commented on patch set 4 01/11/15, 19:21
PageLayoutView.php:1688See line 1684, same applies for $pageUid here -
Mathias Schreiber uploaded patch set 5 01/11/15, 19:42
-
Daniel Maier voted on patch set 5 CR +1 V +1 01/11/15, 20:01
-
Frans Saris commented on patch set 5 01/11/15, 20:10
PageLayoutView.php:1528Why don't you use BackendUtility::getLabelFromItemlist() like Daniel suggested?PageLayoutView.php:1531Just use $row['menu_type'] -
Michael Oehlhof voted on patch set 5 CR +1 V +1 01/11/15, 22:18
-
Markus Klein uploaded patch set 10 01/13/15, 23:00
-
Markus Klein voted on patch set 10 CR +1 01/13/15, 23:00
-
Andreas Kienast voted on patch set 10 CR +1 V +1 01/17/15, 14:22
-
Markus Klein commented on patch set 10 01/17/15, 15:39
Maybe I'm totally on the wrong track with my question.PageLayoutView.php:1528is this always tt_content? What happens when this is a category menu?PageLayoutView.php:1530can't we use an (int) typecast and compare with !== 2? -
Mathias Schreiber commented on patch set 10 01/17/15, 15:44
PageLayoutView.php:1528ReplyThis one is getting the TCA label from the select in tt_content.menu_type. This as nothing to do with the type of menu being selected. Here's what I do: Even if you add your own menu type, or rename the label via TSConfig: it's always made sure the page module displays the correct label.PageLayoutView.php:1530Replysure, but why would we? The field always returns a string.. it's a varchar ;-) It's a special case for the menu type "Sitemap" which does not allow to select pages. But we need this check because you might have selected a different menu type and changed to "Sitemap" later on. In this case we do not want to show the list of selected pages, because it does not comply to the UI of the Backend. -
Philipp Gampe commented on patch set 10 01/17/15, 15:50
this patch misses handling for invalid menu type valuesPageLayoutView.php:1528invalid menu type is not taken into account -
Markus Klein uploaded patch set 11 01/17/15, 17:14
-
Markus Klein voted on patch set 11 CR +1 V +1 01/17/15, 18:04
-
Daniel Maier voted on patch set 11 CR +1 V +1 01/17/15, 18:09
-
Philipp Gampe voted on patch set 11 CR +2 V +2 01/17/15, 18:43
-
Philipp Gampe updated the commit message in patch set 12 01/17/15, 18:53
-
Mathias Schreiber voted on patch set 12 CR +2 V +2 01/17/15, 18:54
-
Philipp Gampe voted on patch set 12 CR +1 V +1 01/17/15, 18:56
-
Philipp Gampe merged patch set 12 01/17/15, 18:56
PageLayoutView.php:1528