Review main Merged

36007[BUGFIX] Add tx_indexedsearch as class alias again

Mathias Schreiber CR +2 V +2 Easy +5 −2 updated 01/14/15, 21:52

Commit message

Registering a "pibase" frontend plugin with addPItoST43($_EXTKEY)
generates a TypoScript snipped for indexed_search like:

plugin.tx_indexdsearch = USER_INT
plugin.tx_indexedsearch.userFunc = tx_indexedsearch->main

The class will be instantiated and main() is called at render
time. There is no easy way to change this. In case of
indexed_search, the "old" class name "tx_indexedsearch" must
be kept as alias to the namespaced class name for the time being
to not trigger a "class not found" fatal error.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1

Files 2

Review log 9

  1. Mathias Schreiber uploaded patch set 1 01/14/15, 14:25

  2. Anja Leichsenring voted on patch set 1 CR +1 V +1 01/14/15, 14:51

  3. Christian Kuhn uploaded patch set 2 01/14/15, 15:19

  4. Christian Kuhn uploaded patch set 3 01/14/15, 15:21

  5. Christian Kuhn uploaded patch set 4 01/14/15, 15:23

  6. Christian Kuhn commented on patch set 4 CR +1 01/14/15, 15:23

    Just rephrased the commit message and removed the class name from ext:compatibility.
  7. Anja Leichsenring voted on patch set 4 CR +1 V +1 01/14/15, 15:42

  8. Christian Kuhn voted on patch set 4 CR +2 V +2 01/14/15, 21:52

  9. Christian Kuhn merged patch set 4 01/14/15, 21:52