Review main Merged

36028[BUGFIX] Make output of additionalCSS valid

Mathias Schreiber CR +2 V +2 Easy +0 −4 updated 01/15/15, 18:40

Commit message

INTincScript_loadJSCode no longer wraps CSS in CDATA tags.
Doing so resulted in invalid CSS markup.

Review

  • Code review CR +2
    • Markus Klein +2
    • Helmut Hummel +2
    • Michael Stucki +1
  • Verified V +2
    • Markus Klein +2
    • Helmut Hummel +1

Files 1

Review log 9

  1. Mathias Schreiber uploaded patch set 1 01/15/15, 17:13

  2. Helmut Hummel updated the commit message in patch set 2 01/15/15, 17:19

  3. Helmut Hummel voted on patch set 2 CR +2 V +1 01/15/15, 17:19

  4. Mathias Schreiber updated the commit message in patch set 3 01/15/15, 17:22

  5. Helmut Hummel voted on patch set 3 CR +2 V +1 01/15/15, 17:23

  6. Michael Stucki voted on patch set 3 CR +1 01/15/15, 17:46

  7. Markus Klein commented on patch set 3 V +2 CR +2 01/15/15, 18:39

    Holy, that issue is 5 years old. Obviously I never used additionalCss otherwise I would have noticed I guess.
  8. Markus Klein merged patch set 3 01/15/15, 18:40

  9. Markus Klein commented on patch set 4 01/15/15, 18:40

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 48d8eb2dd8b369c2a92aa5969e2c85b4295a2cd2