36034[TASK] Only refresh pagetree on certain changes to pages
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Mathias Schreiber +1
- Christian Kuhn +1
-
Verified V +2
- Stefan Neufeind +2
- Mathias Schreiber +1
- Christian Kuhn +1
Issues 1
Files 2
Review log 33
Show 8 earlier messages
-
Stefan Neufeind uploaded patch set 1 01/16/15, 01:02
-
Stefan Neufeind commented on patch set 1 01/16/15, 01:05
Currently the pagetree refreshes on *all* update-operations! With a large pagetree, with multiple levels, that can result in a huge amount of refreshes (for multiple levels). -
Georg Ringer commented on patch set 1 01/16/15, 06:17
DataHandler.php:318I am missing the following field: module. and why raelly public property? -
Stefan Neufeind commented on patch set 1 CR -1 01/16/15, 08:21
We have a list of fields in PageTreeView alreadyDataHandler.php:318ReplyIdea was that we might (later) need to be able for other parts to extend the list. -
Stefan Neufeind uploaded patch set 2 01/16/15, 09:03
-
Stefan Neufeind commented on patch set 2 01/16/15, 09:03
Use fieldArray from the PageTreeView now. It should know which fields it relies on. -
Stefan Neufeind commented on patch set 2 01/16/15, 09:11
As an alternative we could make the pagetree hook itself into hook_processDatamap_afterDatabaseOperations() or so. But imho that makes life harder than necessary. If somebody has a better idea how to solve the coupling of the parts involved, feel free push a new patch-set. -
Mathias Schreiber uploaded patch set 3 01/25/15, 18:07
-
Mathias Schreiber commented on patch set 3 CR +1 V +1 01/25/15, 18:08
Added nav_title to fieldlist because you can configure showing the nav_title via TSconfig -
Christian Kuhn commented on patch set 3 01/25/15, 19:24
gnaa, PageTreeView is on my list of to-be-deprecated classes with my current tree works ... but since the patch is there and it solves the problem for now, mmmh. -
Christian Kuhn commented on patch set 3 CR -1 01/25/15, 19:25
working on it. -
Christian Kuhn commented on patch set 3 01/25/15, 20:14
Reasons not to use PageTreeView in DataHandler: * This adds a dependency from ext:core to ext:backend * $fieldArray is used in PageTreeView to determine the list of fields that should by default be fetched from DB for display. This has nothing to do with a list of fields that should trigger a refresh of the pageTree -
Christian Kuhn commented on patch set 2 01/25/15, 20:16
Actually, I prefer the "hardcoded in DataHandler" solution from patch set 1 in this specific case. -
Christian Kuhn uploaded patch set 4 01/25/15, 20:21
-
Christian Kuhn commented on patch set 4 01/25/15, 20:22
re-pushed set 1 but added nav_title to the list of fields. -
Christian Kuhn uploaded patch set 5 01/25/15, 20:25
-
Christian Kuhn commented on patch set 4 01/25/15, 20:26
added field module ("contains plugin") to the list - this field often changes the icon in page tree. -
Christian Kuhn commented on patch set 5 CR +1 V +1 01/25/15, 20:28
Ok, fine with me. Seems to work good. BTW: Thanks for the patch, the constant reloads of page tree on changing "anything" were really painful. -
Mathias Schreiber voted on patch set 5 CR +1 V +1 01/25/15, 20:32
-
Mathias Schreiber commented on patch set 5 V -1 CR -1 01/25/15, 20:40
working on it -
Stefan Neufeind commented on patch set 5 01/25/15, 20:44
Thanks for the changes so far. I was under the impression that neither AbstractTreeView or PageTreeView loaded for example "siteroot" into the $row, so I didn't have on my list that field of course also affects what is shown in the tree. Mathias mentioned that I overlooked some kind of "overlay" is finally done on the $row again. Taking all that into account I agree it might be a good idea to create a full list of fields to watch for changes (as you have done now). -
Mathias Schreiber uploaded patch set 6 01/25/15, 20:47
-
Mathias Schreiber commented on patch set 6 CR +1 V +1 01/25/15, 20:47
added starttime and endtime because those fields affect the overlay too -
Stefan Neufeind commented on patch set 6 CR -1 01/25/15, 20:55
When working in a workspace, editing a content-element also needs to trigger a page-reload since that will create an overlay. -
Christian Kuhn commented on patch set 6 CR +2 V +2 01/25/15, 20:55
Great. I think that's it for the moment. -
Christian Kuhn voted on patch set 6 CR 0 V 0 01/25/15, 20:56
-
Stefan Neufeind uploaded patch set 7 01/25/15, 21:19
-
Stefan Neufeind commented on patch set 7 01/25/15, 21:20
Works fine now also if any CE is edited in a workspace. We refresh the PageTree there as well, since the page might now get a "modified in workspace"-indicator (which it didn't have before). -
Christian Kuhn voted on patch set 7 CR +1 V +1 01/25/15, 21:22
-
Mathias Schreiber voted on patch set 7 CR +1 V +1 01/25/15, 21:24
-
Stefan Neufeind commented on patch set 7 CR +2 V +2 01/25/15, 21:26
Thanks, gentleman. -
Stefan Neufeind merged patch set 7 01/25/15, 21:26
-
Stefan Neufeind commented on patch set 8 02/16/15, 16:40
Pinged Ernesto again about possibly considering this for 6.2.