Review main Merged

36048[CLEANUP] Correct the type of variable $lineNumberOffset

Michael Oehlhof CR +2 V +2 Easy +1 −1 updated 01/16/15, 19:47

Commit message

The variable $lineNumberOffset is used as an integer in the whole file,
but was declared as string.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Mathias Schreiber +1
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Mathias Schreiber +1
    • Andreas Kienast +1

Issues 1

Files 1

Review log 5

  1. Michael Oehlhof uploaded patch set 1 01/16/15, 18:59

  2. Mathias Schreiber voted on patch set 1 CR +1 V +1 01/16/15, 19:09

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 01/16/15, 19:09

  4. Wouter Wolters voted on patch set 1 V +2 CR +2 01/16/15, 19:47

  5. Wouter Wolters merged patch set 1 01/16/15, 19:47