36140[BUGFIX] Extbase validator should not ask class loader for simple types
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Mathias Schreiber +1
- Oliver Klee +1
- Alexander Opitz +1
- Markus Klein +1
- Mathias Brodala +1
- Philipp Gampe +1
-
Verified V +2
- Benni Mack +2
- Mathias Schreiber +1
- Alexander Opitz +1
Issues 1
Files 1
Review log 16
-
Benni Mack uploaded patch set 1 01/20/15, 12:52
-
Alexander Opitz voted on patch set 1 CR +1 01/20/15, 13:03
-
Mathias Schreiber commented on patch set 1 CR +1 V +1 01/20/15, 13:53
no xdebug hits on string or int -
Mathias Brodala commented on patch set 1 CR -1 01/20/15, 14:08
ValidatorResolver.php:255Please "use" this.ValidatorResolver.php:255Why not !TypeHandlingUtility::isSimpleType()? Comparing boolean with boolean to get boolean is kind of weird. ;-)ValidatorResolver.php:272Same here.ValidatorResolver.php:272Same here. -
Oliver Klee commented on patch set 1 01/20/15, 14:10
Matthias B., will you update the change, or should I do it?ValidatorResolver.php:272I think we can cache the result in a local variable $isLocalType. -
Mathias Brodala commented on patch set 1 01/20/15, 14:19
@Oliver Go ahead, currently only passing by. ;-)ValidatorResolver.php:272ReplyNot really since two different variables are checked here. ($targetClassName VS $propertyTargetClassName) -
Oliver Klee commented on patch set 1 01/20/15, 17:47
ValidatorResolver.php:255ReplyDoneValidatorResolver.php:255ReplyDoneValidatorResolver.php:272ReplyDoneValidatorResolver.php:272ReplyDone -
Oliver Klee uploaded patch set 2 01/20/15, 17:47
-
Oliver Klee voted on patch set 2 CR +1 01/20/15, 17:48
-
Markus Klein voted on patch set 2 CR +1 01/20/15, 22:34
-
Mathias Brodala voted on patch set 2 CR +1 01/21/15, 07:14
-
Alexander Opitz voted on patch set 2 V +1 CR +1 01/21/15, 09:29
-
Philipp Gampe voted on patch set 2 CR +1 01/22/15, 09:39
-
Mathias Schreiber voted on patch set 2 CR +1 V +1 01/24/15, 22:20
-
Benni Mack voted on patch set 2 CR +2 V +2 01/24/15, 22:22
-
Benni Mack merged patch set 2 01/24/15, 22:22