Review main Merged

36143[CLEANUP] Correct phpdoc in extbase's validator classes

Frederic Gaus CR +2 V +2 Easy +10 −24 updated 01/22/15, 20:57

Commit message

Set the correct @return in phpdoc of extbase validators.
Further correct some typos and remove disabled code including a
not needed comment in ValidatorInterface

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 6

Review log 8

  1. Frederic Gaus uploaded patch set 1 01/20/15, 16:49

  2. Mathias Schreiber voted on patch set 1 CR +1 V +1 01/20/15, 16:50

  3. Markus Klein commented on patch set 1 CR -1 01/20/15, 22:36

    BooleanValidator.php:36

    huh?

    DateTimeValidator.php:27

    no result here
  4. Frederic Gaus uploaded patch set 2 01/21/15, 07:29

  5. Oliver Klee voted on patch set 2 CR +1 01/21/15, 10:30

  6. Markus Klein voted on patch set 2 CR +1 V +1 01/22/15, 20:55

  7. Wouter Wolters voted on patch set 2 V +2 CR +2 01/22/15, 20:57

  8. Wouter Wolters merged patch set 2 01/22/15, 20:57