Review main Merged

36148[TASK] Deprecate direct method calls to cObjects

Benni Mack CR +2 V +2 Normal +153 −34 updated 01/25/15, 12:21

Commit message

Some (but not all) cObjects used the shorthand calls
inside ContentObjectRenderer which come from the time
before TYPO3 4.5 where all the code was inside
ContentObjectRenderer.

They are now finally marked for deprecation.

All places within the TYPO3 Core are replaced
with the appropriate public API call.

Review

  • Code review CR +2
    • Markus Klein +2
    • Mathias Schreiber +1
  • Verified V +2
    • Markus Klein +2
    • Mathias Schreiber +1

Issues 1

Files 13

Review log 7

  1. Benni Mack uploaded patch set 1 01/20/15, 20:47

  2. Markus Klein commented on patch set 1 01/20/15, 22:23

    Deprecation-64388-ContentObjectMethods.rst:58

    method calls

    ContentObjectRenderer.php:452

    remove the 's
  3. Benni Mack uploaded patch set 2 01/22/15, 19:08

  4. Mathias Schreiber updated the commit message in patch set 3 01/24/15, 22:59

  5. Mathias Schreiber voted on patch set 3 CR +1 V +1 01/24/15, 22:59

  6. Markus Klein commented on patch set 3 CR +2 V +2 01/25/15, 12:21

    I hope we didn't miss a call.
  7. Markus Klein merged patch set 3 01/25/15, 12:21