36153[TASK] Drop support and tests for FreeType 1
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2
- Anja Leichsenring +2
- Christian Kuhn +1
Issues 1
Files 9
- typo3/sysext/core/Classes/Utility/GeneralUtility.php5+8 −9
- typo3/sysext/core/Configuration/DefaultConfiguration.php1+0 −1
- typo3/sysext/install/Classes/Controller/Action/Tool/TestSetup.php+7 −8
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+3 −1
- typo3/sysext/install/Classes/SystemEnvironment/Check.php+4 −4
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/TestSetup/TrueTypeFont.htmlrenamed+3 −3
- typo3/sysext/install/Resources/Private/Templates/Action/Tool/TestSetup.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Action/Tool/Welcome.html+1 −1
- INSTALL.md+1 −1
Review log 21
-
Stefan Neufeind uploaded patch set 1 01/21/15, 08:45
-
Stefan Neufeind commented on patch set 1 01/21/15, 08:47
Imho we keep the freetypeDpiComp-method in GeneralUtility, since it still translates between font-sizes and "pixels" (depending on the dpi), right? Do we call it "FreeType 2" or "freetype2"? Used different in some places. For this patch I used "FreeType 2". Note that the testreference-file still mentions the dpi-setting and that the reference-images were created with TYPO3 3.8 on PHP4 :-) typo3/sysext/install/Resources/Public/Images/TestReference/About.txt -
Stefan Neufeind commented on patch set 1 CR -1 01/21/15, 08:51
Update in a minute. -
Stefan Neufeind uploaded patch set 2 01/21/15, 09:00
-
Stefan Neufeind commented on patch set 2 01/21/15, 09:00
In the installtool-test I get a "Maximum function nesting level of '100' reached". Unsure why ... Any place I missed? -
Oliver Klee commented on patch set 2 01/21/15, 10:29
GeneralUtility.php:4878Isn't this a float?GeneralUtility.php:4883I think we can now directly return it. -
Stefan Neufeind commented on patch set 2 01/22/15, 21:38
@Oliver: Could you maybe give it a try and see if in the install-tool it also fails for you with the maximum nesting level? If so, what did I overlook?GeneralUtility.php:4878ReplyHmm, just checked. Yes, it results in a double. Is that fine in other places? (It has always been like that.) Should we maybe define the input as float/double as well?GeneralUtility.php:4883Replyack -
Oliver Klee commented on patch set 2 01/22/15, 21:52
Stefan, are you sure the comment about the max nesting level belong in this change?GeneralUtility.php:4878ReplyI have no idea how it is in other places. Changing the @param to float would be fine with me, too. (And there is no type "double" in PHP AFAIK, only float.) -
Stefan Neufeind commented on patch set 2 01/22/15, 22:04
Yes, I had the nesting-level-problem when trying to display the test-images in the install-tool. Showed the error for me and didn't proceed to generate the images. -
Benni Mack commented on patch set 2 01/30/15, 16:30
Stefan, good catch, can you rebase? -
Oliver Klee commented on patch set 2 01/30/15, 17:07
I'll take care of the rebase. -
Oliver Klee uploaded patch set 3 01/30/15, 17:13
-
Oliver Klee commented on patch set 3 CR -1 01/30/15, 17:15
DefaultConfiguration.php:42Cough… -
Oliver Klee uploaded patch set 4 01/30/15, 17:16
-
Oliver Klee voted on patch set 4 CR +1 01/30/15, 17:16
-
Christian Kuhn commented on patch set 4 CR -1 01/30/15, 17:52
removing the setting in silent upgrade wizard is missing. will push update -
Christian Kuhn uploaded patch set 5 01/30/15, 17:58
-
Christian Kuhn voted on patch set 5 CR +1 V +1 01/30/15, 17:58
-
Oliver Klee voted on patch set 5 CR +1 01/30/15, 18:00
-
Anja Leichsenring voted on patch set 5 CR +2 V +2 01/30/15, 19:01
-
Anja Leichsenring merged patch set 5 01/30/15, 19:01