Review main Merged

36208[BUGFIX] Scheduler now throws exception on SQL query error

Mathias Schreiber CR +2 V +2 Easy +3 −0 updated 01/26/15, 01:12

Commit message

If the query for fetchTask fails for whatever reason, scheduler will
now gracefully throw an exception instead of assuming it had gotten
a valid resource pointer

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Julian Hofmann +1
    • Andreas Kienast +1
    • Michael Oehlhof +1
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 14

  1. Mathias Schreiber uploaded patch set 1 01/23/15, 20:32

  2. Michael Oehlhof voted on patch set 1 CR +1 01/23/15, 20:51

  3. Philipp Gampe commented on patch set 1 01/24/15, 10:29

    IMHO the exception should be more specific. Anyway how can the table become broken? How do you make scheduler query an invalid uid?
  4. Philipp Gampe commented on patch set 1 01/24/15, 10:38

    unexpectedValueException should do the job here
  5. Mathias Schreiber uploaded patch set 2 01/24/15, 10:50

  6. Michael Oehlhof voted on patch set 2 CR +1 01/24/15, 10:53

  7. Julian Hofmann commented on patch set 2 CR +1 01/24/15, 11:00

    @Philipp: Can be broken due to improper copies of the TYPO3 installation or damaged tables. Don't know the reason, it has been in me case over 2 years ago.
  8. Mathias Schreiber commented on patch set 2 01/24/15, 11:01

    I think we can agree this one is very situational, but the if shouldn't do harm
  9. Andreas Kienast voted on patch set 2 CR +1 01/24/15, 12:09

  10. Philipp Gampe voted on patch set 2 CR +1 01/24/15, 13:55

  11. Christian Kuhn voted on patch set 2 CR +1 V +1 01/26/15, 01:06

  12. Christian Kuhn commented on patch set 2 CR +2 V +2 01/26/15, 01:11

    tested. Patch is no-brainish and won't harm. the exception is changed to a flash message later on if called in backend.
  13. Christian Kuhn merged patch set 2 01/26/15, 01:12

  14. Christian Kuhn commented on patch set 3 01/26/15, 01:12

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit d1fead271393b9f94a34cbe3e1915c32a73c871b