Review main Merged

36209[BUGFIX] Scheduler now offers an enable/disable toggle in list view

Mathias Schreiber CR +2 V +2 Easy +25 −1 updated 01/24/15, 23:53

Commit message

In order to quickly enable or disable tasks we introduced a new toggle
control in the list view.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Brodala +1
    • Michael Oehlhof +1
  • Verified V +2
    • Benni Mack +2
    • Michael Oehlhof +1

Issues 1

Files 1

Review log 17

  1. Mathias Schreiber uploaded patch set 1 01/23/15, 20:56

  2. Philipp Gampe commented on patch set 1 01/24/15, 10:24

    did you check whether this keeps being synced with the corresponding state inside the object? Otherwise we might result funny bugs ... at least I remember such problems from a couple years ago.
  3. Mathias Schreiber uploaded patch set 2 01/24/15, 10:46

  4. Philipp Gampe voted on patch set 2 CR +2 V +2 01/24/15, 11:04

  5. Philipp Gampe voted on patch set 2 CR +1 V +1 01/24/15, 11:04

  6. Philipp Gampe commented on patch set 2 01/24/15, 11:04

    first toggle need two clicks, but then it works
  7. Andreas Kienast commented on patch set 2 CR -1 01/24/15, 12:02

    I'm on it
  8. Andreas Kienast uploaded patch set 3 01/24/15, 12:05

  9. Philipp Gampe voted on patch set 3 CR +1 V +1 01/24/15, 13:58

  10. Mathias Brodala commented on patch set 3 CR -1 01/24/15, 15:06

    SchedulerModuleController.php:523

    Why not simplify to $task->setDisabled(!$task->isDisabled())?
  11. Andreas Kienast uploaded patch set 4 01/24/15, 15:10

  12. Mathias Schreiber commented on patch set 3 01/24/15, 15:11

    do whatever you like

    SchedulerModuleController.php:523 Reply

    at least to me this reads horribly
  13. Mathias Brodala voted on patch set 4 CR +1 01/24/15, 15:13

  14. Mathias Brodala commented on patch set 4 01/24/15, 15:21

    I'd argue that this goes along the same line as "return 1 === 1 ? TRUE : FALSE"; if you have a boolean already, why not use it right away? ;-)
  15. Michael Oehlhof voted on patch set 4 CR +1 V +1 01/24/15, 23:29

  16. Benni Mack voted on patch set 4 CR +2 V +2 01/24/15, 23:53

  17. Benni Mack merged patch set 4 01/24/15, 23:53