36209[BUGFIX] Scheduler now offers an enable/disable toggle in list view
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Mathias Brodala +1
- Michael Oehlhof +1
-
Verified V +2
- Benni Mack +2
- Michael Oehlhof +1
Issues 1
Files 1
Review log 17
-
Mathias Schreiber uploaded patch set 1 01/23/15, 20:56
-
Philipp Gampe commented on patch set 1 01/24/15, 10:24
did you check whether this keeps being synced with the corresponding state inside the object? Otherwise we might result funny bugs ... at least I remember such problems from a couple years ago. -
Mathias Schreiber uploaded patch set 2 01/24/15, 10:46
-
Philipp Gampe voted on patch set 2 CR +2 V +2 01/24/15, 11:04
-
Philipp Gampe voted on patch set 2 CR +1 V +1 01/24/15, 11:04
-
Philipp Gampe commented on patch set 2 01/24/15, 11:04
first toggle need two clicks, but then it works -
Andreas Kienast commented on patch set 2 CR -1 01/24/15, 12:02
I'm on it -
Andreas Kienast uploaded patch set 3 01/24/15, 12:05
-
Philipp Gampe voted on patch set 3 CR +1 V +1 01/24/15, 13:58
-
Mathias Brodala commented on patch set 3 CR -1 01/24/15, 15:06
SchedulerModuleController.php:523Why not simplify to $task->setDisabled(!$task->isDisabled())? -
Andreas Kienast uploaded patch set 4 01/24/15, 15:10
-
Mathias Schreiber commented on patch set 3 01/24/15, 15:11
do whatever you likeSchedulerModuleController.php:523Replyat least to me this reads horribly -
Mathias Brodala voted on patch set 4 CR +1 01/24/15, 15:13
-
Mathias Brodala commented on patch set 4 01/24/15, 15:21
I'd argue that this goes along the same line as "return 1 === 1 ? TRUE : FALSE"; if you have a boolean already, why not use it right away? ;-) -
Michael Oehlhof voted on patch set 4 CR +1 V +1 01/24/15, 23:29
-
Benni Mack voted on patch set 4 CR +2 V +2 01/24/15, 23:53
-
Benni Mack merged patch set 4 01/24/15, 23:53