Review TYPO3_6-2 Merged

36241[BUGFIX] Extbase validator should not ask class loader for simple types

Benni Mack CR +2 V +2 Easy +15 −9 updated 01/26/15, 13:56

Commit message

Extbase calls class_exists multiple times to
check for valid classes during set up of Validator
classes. It does these checks even for types
like "string" and "integer" for each
This leads to unnecessary calls to
the TYPO3 class loader and can be avoided.

Review

  • Code review CR +2
    • Alexander Opitz +2
    • Mathias Schreiber +1
    • Oliver Klee +1
  • Verified V +2
    • Alexander Opitz +2
    • Mathias Schreiber +1

Issues 1

Files 1

Review log 8

  1. Benni Mack uploaded patch set 1 01/24/15, 22:28

  2. Mathias Schreiber voted on patch set 1 CR +1 V +1 01/24/15, 22:43

  3. Oliver Klee voted on patch set 1 CR +1 01/25/15, 00:39

  4. Markus Klein updated the commit message in patch set 2 01/25/15, 12:15

  5. Mathias Schreiber voted on patch set 2 CR +1 V +1 01/25/15, 12:31

  6. Oliver Klee voted on patch set 2 CR +1 01/25/15, 17:25

  7. Alexander Opitz voted on patch set 2 V +2 CR +2 01/26/15, 13:56

  8. Alexander Opitz merged patch set 2 01/26/15, 13:56