36252[BUGFIX] Move nav_title from AbstractTreeView to PageTreeView
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Mathias Schreiber +1
-
Verified V +2
- Christian Kuhn +2
- Mathias Schreiber +1
Issues 1
Files 3
Review log 9
-
Stefan Neufeind uploaded patch set 1 01/25/15, 19:23
-
Stefan Neufeind commented on patch set 1 01/25/15, 19:25
AbstractTreeView.phpAbstractTreeView only knows about a "title"-field. Everything else is just for the PageTreeView. -
Christian Kuhn commented on patch set 1 01/25/15, 20:04
fieldArray is used to determine which fields are fetched from database. you're now adding nav_title as "fetch it always", so other code that uses this class now also gets this field, even if it does not use it (like beuser PermissionController). This is not too cool, but fine with me, since all these tree classes will hopefully be killed soon anyway. However, this patch is not a bugfix but an architectural cleanup [TASK]. There is no need to have it in 6.2. -
Christian Kuhn updated the commit message in patch set 2 01/25/15, 20:04
-
Christian Kuhn voted on patch set 2 CR +1 V +1 01/25/15, 20:07
-
Mathias Schreiber voted on patch set 2 CR +1 V +1 01/25/15, 20:08
-
Christian Kuhn voted on patch set 2 CR +2 V +2 01/25/15, 20:10
-
Christian Kuhn merged patch set 2 01/25/15, 20:10
-
Stefan Neufeind commented on patch set 3 01/25/15, 23:06
Thanks for taking care. The "bugfix"-aspect of this imho was that AbstractTreeView might try to access $row['nav_title'] which wasn't already fetched.
PageTreeNavigationController.php:118