Review main Merged

36339[BUGFIX] Correct trim of trailing slash

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 03/11/15, 19:53

Commit message

The trailing slash was accidentally trimmed of $expectedTarget, which
never has a trailing slash. Remove the slash from $actualTarget now.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mateusz Wojtuła +1
  • Verified V +2
    • Christian Kuhn +2
    • Mateusz Wojtuła +1

Issues 1

Files 2

Review log 12

  1. Andreas Kienast uploaded patch set 1 01/28/15, 21:25

  2. Andreas Kienast wrote 01/28/15, 21:26

    Topic set to EXT: install
  3. Daniel Maier voted on patch set 1 CR +1 01/28/15, 21:58

  4. Frederic Gaus voted on patch set 1 CR +1 V +1 01/28/15, 22:31

  5. Christian Kuhn commented on patch set 1 CR -1 01/29/15, 09:30

    The FolderStructure code has a pretty high unit test coverage already. Would be great to add one for this issue.
  6. Mateusz Wojtuła commented on patch set 1 CR -1 01/29/15, 11:28

    I am picking this and add some tests for it.
  7. Mateusz Wojtuła uploaded patch set 2 01/29/15, 12:31

  8. Mateusz Wojtuła voted on patch set 2 CR +1 V +1 01/29/15, 12:38

  9. Christian Kuhn voted on patch set 2 CR +2 V +2 01/29/15, 12:39

  10. Christian Kuhn merged patch set 2 01/29/15, 12:39

  11. Stephan Großberndt commented on patch set 3 03/05/15, 21:50

    Not backported, but Releases: master, 6.2. Shall I backport it?
  12. Stephan Großberndt commented on patch set 3 03/11/15, 19:53