Review main Merged

36342[BUGFIX] Change highlight color on folder change

Benni Mack CR +2 V +2 Easy +1 −1 updated 01/29/15, 17:35

Commit message

Clicking on folder in filelist results in JS error.

When using the filelist main frame
for navigation through the folder structure
there is still some leftover from the old
code, which changes the highlighted
item when clicking on a folder.

The patch solves the issue by properly
addressing the navigation frame and
the JS method.

This part is actually a leftover from pre-4.2
code which was not changed by me in 4.2
with the introduction of the AJAX-based
folder tree with prototype.js.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Alexander Opitz +1
    • Jan Helke +1
    • Christian Kuhn +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Alexander Opitz +1
    • Jan Helke +1
    • Christian Kuhn +1

Issues 1

Files 1

Review log 15

  1. Benni Mack uploaded patch set 1 01/29/15, 09:47

  2. Benni Mack updated the commit message in patch set 2 01/29/15, 09:51

  3. Tymoteusz Motylewski voted on patch set 2 CR +1 V +1 01/29/15, 17:08

  4. Jan Helke voted on patch set 2 CR +1 V +1 01/29/15, 17:29

  5. Alexander Opitz voted on patch set 2 V +1 CR +1 01/29/15, 17:29

  6. Christian Kuhn commented on patch set 2 CR +1 V +1 01/29/15, 17:30

    please wait with merge for a second.
  7. Zbigniew Jacko voted on patch set 2 V +1 CR +1 01/29/15, 17:31

  8. Benni Mack updated the commit message in patch set 3 01/29/15, 17:31

  9. Christian Kuhn voted on patch set 3 CR +1 V +1 01/29/15, 17:31

  10. Jan Helke voted on patch set 3 CR +1 V +1 01/29/15, 17:31

  11. Alexander Opitz voted on patch set 3 V +1 CR +1 01/29/15, 17:31

  12. Tymoteusz Motylewski voted on patch set 3 CR +1 V +1 01/29/15, 17:33

  13. Tymoteusz Motylewski voted on patch set 3 CR +2 V +2 01/29/15, 17:33

  14. Tymoteusz Motylewski merged patch set 3 01/29/15, 17:33

  15. Tymoteusz Motylewski commented on patch set 4 01/29/15, 17:35

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit dbeef18964b565b86bc8bd5bd38ce89c79df4807