Review main Merged

36345[BUGFIX] Keep linktype on core update

Frederic Gaus CR +2 V +2 Easy +20 −0 updated 02/02/15, 20:56

Commit message

Keep the linktype of the symlink pointing to the TYPO3 core. Currently
the CoreUpdateService always creates an absolute link even if the
link was relative before. This patch checks for the correct link type
during a core update. This could be important in some environments,
e.g. in a chrooted environemnt.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Mathias Schreiber +1
    • Göran Bodenschatz +1
  • Verified V +2
    • Stefan Neufeind +2
    • Mathias Schreiber +1

Issues 1

Files 1

Review log 12

  1. Frederic Gaus uploaded patch set 1 01/29/15, 10:17

  2. Wouter Wolters updated the commit message in patch set 2 01/29/15, 10:21

  3. Andreas Kienast commented on patch set 2 CR -1 01/29/15, 15:57

    on it, fixing a nitpick
  4. Andreas Kienast uploaded patch set 3 01/29/15, 16:00

  5. Frederic Gaus uploaded patch set 4 01/30/15, 09:05

  6. Frederic Gaus commented on patch set 4 01/30/15, 09:05

    rebased
  7. Mathias Schreiber voted on patch set 4 CR +1 02/02/15, 16:01

  8. Mathias Schreiber voted on patch set 4 V +1 02/02/15, 16:17

  9. Göran Bodenschatz voted on patch set 4 CR +1 02/02/15, 20:10

  10. Stefan Neufeind commented on patch set 4 CR +1 V -1 02/02/15, 20:47

    testing
  11. Stefan Neufeind voted on patch set 4 CR +2 V +2 02/02/15, 20:56

  12. Stefan Neufeind merged patch set 4 02/02/15, 20:56