36370[TASK] Add title for 'edit localized metadata' button
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Zbigniew Jacko +1
- Christian Kuhn +1
-
Verified V +2
- Anja Leichsenring +2
- Zbigniew Jacko +1
- Christian Kuhn +1
Issues 1
Files 2
Review log 14
-
Jan Helke uploaded patch set 1 01/29/15, 16:41
-
Zbigniew Jacko voted on patch set 1 V +1 CR +1 01/29/15, 17:01
-
Tymoteusz Motylewski updated the commit message in patch set 2 01/29/15, 17:19
-
Tymoteusz Motylewski commented on patch set 2 CR -1 01/29/15, 17:21
can you add a description like "Edit metadata of this file in language: $languageName" for this button? In my opinion adding just the language name doesn't explain what this button does. -
Zbigniew Jacko commented on patch set 2 01/29/15, 17:26
If you add: "Edit metadata of this file in language: $languageName" I think that for not translated element should be also 'Create metadata of this file in language: $languageName' -
Jan Helke uploaded patch set 3 01/30/15, 09:48
-
Zbigniew Jacko voted on patch set 3 V +1 CR +1 01/30/15, 09:51
-
Christian Kuhn commented on patch set 3 CR -1 01/30/15, 10:26
FileList.php:633If the according language should be displayed too, it should be added as argument to the label (it could eg. happen that different language have a different order of words and need to resort). Please also make sure that title is htmlspecialchar'd before outputting.FileList.php:648same here. -
Jan Helke uploaded patch set 4 01/30/15, 12:48
-
Christian Kuhn uploaded patch set 5 01/30/15, 12:54
-
Christian Kuhn voted on patch set 5 CR +1 V +1 01/30/15, 12:54
-
Zbigniew Jacko voted on patch set 5 V +1 CR +1 01/30/15, 12:57
-
Anja Leichsenring voted on patch set 5 CR +2 V +2 01/30/15, 13:15
-
Anja Leichsenring merged patch set 5 01/30/15, 13:15