Review main Merged

36391[BUGFIX] Add missing htmlspecialchars in DocumentTemplate

Sascha Egerer CR +2 V +2 Easy +9 −2 updated 01/30/15, 13:04

Commit message

XSS is possible when using a special filename. The file has to be
created directly in the storage as uploading files with those names
is not possible.
Add a missing htmlspecialchars to prevent html injection.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Ingo Schmitt +1
    • Michael Oehlhof +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Michael Oehlhof +1

Issues 1

Files 2

Review log 8

  1. Sascha Egerer uploaded patch set 1 01/29/15, 22:47

  2. Sascha Egerer updated the commit message in patch set 2 01/29/15, 22:49

  3. Ingo Schmitt voted on patch set 2 CR +1 01/29/15, 23:03

  4. Mathias Schreiber voted on patch set 2 CR +1 V +1 01/30/15, 10:28

  5. Michael Oehlhof voted on patch set 2 CR +1 V +1 01/30/15, 12:06

  6. Christian Kuhn voted on patch set 2 CR +2 V +2 01/30/15, 13:01

  7. Christian Kuhn merged patch set 2 01/30/15, 13:02

  8. Christian Kuhn commented on patch set 3 01/30/15, 13:04

    No backport! Patch is not relevant for 6.2 (found out after merging).