Review main Merged

36416[BUGFIX] Take table permissions in account for file edit icon

Philipp Thiele CR +2 V +2 Easy +13 −12 updated 01/31/15, 11:33

Commit message

Hides the file edit icon in filelist if the user has no modify
permissions for sys_file_metadata.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Mathias Schreiber +1
    • Nicole Hummel +1
  • Verified V +2
    • Anja Leichsenring +2
    • Mathias Schreiber +1
    • Nicole Hummel +1

Issues 1

Files 3

Review log 24

  1. Philipp Thiele uploaded patch set 1 01/30/15, 12:38

  2. Doreen Gröger commented on patch set 1 01/30/15, 13:40

    Testing now
  3. Philipp Thiele commented on patch set 1 V -1 01/30/15, 14:08

    i will provide another patch, i missed the click menu
  4. Philipp Thiele uploaded patch set 2 01/30/15, 14:28

  5. Philipp Gampe voted on patch set 2 CR +1 01/30/15, 16:03

  6. Philipp Gampe commented on patch set 2 V -1 01/30/15, 16:03

    waiting for cleanup patch
  7. Doreen Gröger voted on patch set 2 V +1 01/30/15, 17:05

  8. Philipp Thiele uploaded patch set 3 01/30/15, 17:10

  9. Philipp Gampe commented on patch set 3 V -1 CR -1 01/30/15, 18:02

    needs to take care of the edit icons in TCE forms too
  10. Philipp Thiele uploaded patch set 4 01/30/15, 19:21

  11. Frans Saris voted on patch set 4 CR +1 V +1 01/30/15, 19:53

  12. Stefan Froemken voted on patch set 4 CR +1 01/30/15, 22:01

  13. Helmut Hummel uploaded patch set 5 01/31/15, 11:10

  14. Ingo Schmitt voted on patch set 4 CR +1 01/31/15, 11:12

  15. Ingo Schmitt voted on patch set 4 V +1 01/31/15, 11:12

  16. Mathias Schreiber uploaded patch set 6 01/31/15, 11:18

  17. Markus Klein voted on patch set 6 CR +1 01/31/15, 11:20

  18. Mathias Schreiber commented on patch set 6 CR -2 01/31/15, 11:20

    gnaaaaa on it
  19. Markus Klein commented on patch set 6 01/31/15, 11:20

    Shouldn't this go into 6.2 as well?
  20. Mathias Schreiber uploaded patch set 7 01/31/15, 11:23

  21. Mathias Schreiber voted on patch set 7 CR +1 V +1 01/31/15, 11:23

  22. Nicole Hummel voted on patch set 7 CR +1 V +1 01/31/15, 11:27

  23. Anja Leichsenring voted on patch set 7 CR +2 V +2 01/31/15, 11:33

  24. Anja Leichsenring merged patch set 7 01/31/15, 11:33