Review main Merged

36438[BUGFIX] Adjust visibility of setUp() and tearDown()

Anja Leichsenring CR +2 V +2 Hard +328 −328 updated 01/30/15, 18:37

Commit message

Protected is the correct visibility for those functions, as
given by the base class.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2
    • Helmut Hummel +2
    • Oliver Klee +1
    • Christian Kuhn +1

Issues 1

Files 297

Show 277 more files

Review log 17

  1. Anja Leichsenring uploaded patch set 1 01/30/15, 15:21

  2. Anja Leichsenring uploaded patch set 2 01/30/15, 15:27

  3. Wouter Wolters voted on patch set 2 V +1 CR +1 01/30/15, 18:14

  4. Christian Kuhn commented on patch set 2 01/30/15, 18:15

    working on it.
  5. Helmut Hummel voted on patch set 2 CR -1 01/30/15, 18:18

  6. Oliver Klee voted on patch set 2 V +1 CR +1 01/30/15, 18:19

  7. Christian Kuhn commented on patch set 2 CR -1 01/30/15, 18:20

    thousands of warnings in functional tests.
  8. Christian Kuhn voted on patch set 2 CR 0 V -1 01/30/15, 18:20

  9. Oliver Klee voted on patch set 2 V -1 CR 0 01/30/15, 18:20

  10. Helmut Hummel commented on patch set 2 01/30/15, 18:25

    FunctionalTestCaseBootstrapUtility.php:78

    This change is wrong!
  11. Anja Leichsenring uploaded patch set 3 01/30/15, 18:27

  12. Oliver Klee voted on patch set 3 CR +1 01/30/15, 18:33

  13. Christian Kuhn voted on patch set 3 CR +1 V +1 01/30/15, 18:34

  14. Oliver Klee voted on patch set 3 V +1 01/30/15, 18:35

  15. Helmut Hummel voted on patch set 3 CR +1 V +1 01/30/15, 18:37

  16. Helmut Hummel voted on patch set 3 CR +2 V +2 01/30/15, 18:37

  17. Helmut Hummel merged patch set 3 01/30/15, 18:37