Review main Merged

36461[BUGFIX] Disable functionality to hide file storage

Ruud Silvrants CR +2 V +2 Hard +277 −282 updated 07/15/15, 18:46

Commit message

Disables the functionality to hide a file storage.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Anja Leichsenring +1
  • Verified V +2
    • Helmut Hummel +2
    • Anja Leichsenring +1

Issues 1

Files 3

Review log 20

  1. Ruud Silvrants uploaded patch set 1 01/30/15, 18:02

  2. Ingo Schmitt voted on patch set 1 CR +1 V +1 01/30/15, 18:11

  3. Ingo Schmitt wrote 01/30/15, 18:14

    Removed the following approvals: * Code-Review+1 by Ingo Schmitt <is@marketing-factory.de> * Verified+1 by Ingo Schmitt <is@marketing-factory.de>
  4. Ingo Schmitt commented on patch set 1 CR -1 V -1 01/30/15, 18:14

    Should be done in core/Configuration/TCA/sys_file_storage.php
  5. Ruud Silvrants uploaded patch set 2 01/30/15, 18:19

  6. Helmut Hummel updated the commit message in patch set 3 01/30/15, 18:49

  7. Helmut Hummel commented on patch set 3 CR -1 01/30/15, 18:54

    not sure what the benefit is to get this into 6.2 It changes db schema which in general should only be done in exceptionally important situations. we can merge the TCA change in 6.2 but not the db schema change
  8. Helmut Hummel voted on patch set 3 CR 0 01/30/15, 18:54

  9. Stefan Froemken commented on patch set 3 V -1 CR -1 01/30/15, 18:57

    If you delete a col from a table, it would be good to remove this col from key, too.
  10. Helmut Hummel uploaded patch set 4 01/30/15, 19:01

  11. Anja Leichsenring voted on patch set 4 CR +1 V +1 01/30/15, 19:04

  12. Helmut Hummel commented on patch set 4 01/30/15, 19:05

    fixed some indentation issues and fixed the key definition
  13. Helmut Hummel voted on patch set 4 CR +2 V +2 01/30/15, 19:05

  14. Helmut Hummel merged patch set 4 01/30/15, 19:05

  15. Stefan Froemken commented on patch set 4 01/30/15, 19:08

    ext_tables.sql:276

    Please remove that, too. It does not make sence to have a key where over 50% of records have the same value.
  16. Stefan Froemken commented on patch set 4 01/30/15, 19:17

    sys_file_storage.php:29

    If you delete cols, please delte TCA entrys, too.
  17. Frans Saris commented on patch set 4 01/30/15, 20:24

    Will create a followup for removing the remaining TCA configuration
  18. Ingo Schmitt commented on patch set 4 01/30/15, 20:44

    ext_tables.sql:276 Reply

    No. If no key, all queries for a storage will result in a Full Table Scan.
  19. Markus Klein commented on patch set 5 06/03/15, 10:53

    Question in the ticket regarding a 6.2 fix for this! Please answer
  20. Stefan Froemken commented on patch set 4 07/15/15, 18:46

    ext_tables.sql:276 Reply

    if you had a book on databases and indexed the word "database", you'd see that it's mentioned on pages 1-59,61-290, and 292 to 400. In such case, the index is not much help and it might be faster to go through the pages one by one (in a database, this is "poor selectivity"). Link: http://stackoverflow.com/questions/3567981/how-do-mysql-indexes-work