Review main Merged

36462[TASK] Always display errors when running the tests

Oliver Klee CR +2 V +2 Easy +10 −0 updated 01/30/15, 18:26

Commit message

With some default php.ini files (e.g., the file shipped with MAMP PRO),
display_errors is set to "off", and the memory limit is rather low.

As the bootstraps for the unit and functional tests do not read the
current installation's settings, the default values from the php.ini
are used. This can cause the tests to fail at some point due to
insufficient memory, but without any visible messages.

This change makes sure that PHP errors always are output when running
the unit or functional tests using the Core bootstrap files.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 8

  1. Oliver Klee uploaded patch set 1 01/30/15, 18:04

  2. Oliver Klee commented on patch set 1 01/30/15, 18:06

    How to test: 1. Set memory_limit=99M and display_errors=Off in your php.ini. 2. run the unit tests using the Bootstrap Without this patch, the tests will fail silently. With the patch, you will get an error message.
  3. Oliver Klee uploaded patch set 2 01/30/15, 18:13

  4. Christian Kuhn voted on patch set 2 CR +1 V +1 01/30/15, 18:23

  5. Wouter Wolters voted on patch set 2 V +1 CR +2 01/30/15, 18:25

  6. Christian Kuhn voted on patch set 2 CR +2 V +2 01/30/15, 18:25

  7. Christian Kuhn merged patch set 2 01/30/15, 18:25

  8. Christian Kuhn commented on patch set 3 01/30/15, 18:26

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit c6f19b34eb3ae77735a1187d3deb16e3fb544fb6