36472[FEATURE] Display the bad class name in makeInstance
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2
- Benni Mack +2
- Christian Kuhn +1
Issues 1
Files 1
Review log 9
-
Oliver Klee uploaded patch set 1 01/30/15, 19:55
-
Oliver Klee commented on patch set 1 01/30/15, 19:57
How to test: Run the current (erroring) unit tests of the phpunit extension in the BE module and have a look at the error messages. :-) -
Stefan Froemken commented on patch set 1 01/30/15, 20:42
GeneralUtility.php:4344delete empty lineGeneralUtility.php:4346here, too -
Benni Mack commented on patch set 1 01/30/15, 20:42
Should we do a HSC? -
Oliver Klee commented on patch set 1 01/30/15, 21:34
No, not for the exception message. The correct place for hsc is just before the output in the corresponding context, i.e., when including it on a page. That is part of the error handler, not of the code throwing an exception. -
Oliver Klee commented on patch set 1 01/30/15, 21:35
GeneralUtility.php:4344ReplyI added the lines to have more visual separation between the annotation types. Do we have something in the CGL about whether to have empty lines there? -
Christian Kuhn voted on patch set 1 CR +1 V +1 01/30/15, 21:37
-
Benni Mack commented on patch set 1 CR +2 V +2 01/30/15, 21:38
GREAT stuff! -
Benni Mack merged patch set 1 01/30/15, 21:38