Review main Abandoned

36475[WIP][TASK] Make use of phpunit after tearDown execution

Mateusz Wojtuła CR 0 V 0 Easy +3 −42 updated 01/30/15, 20:47

Commit message

Since a latest release of phpunit it is possible
to tag a function as to be executed after frameworks tearDown().

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 38

Show 18 more files

Review log 6

  1. Mateusz Wojtuła uploaded patch set 1 01/30/15, 20:08

  2. Mateusz Wojtuła uploaded patch set 2 01/30/15, 20:12

  3. Oliver Klee commented on patch set 1 01/30/15, 20:13

    UnitTestCase.php:53

    Why this annotation?

    UnitTestCase.php:96

    This shouldn't be part of this change, I assume?
  4. Oliver Klee commented on patch set 2 01/30/15, 20:14

    UnitTestCase.php:53

    Why this annotation?
  5. Anja Leichsenring commented on patch set 2 01/30/15, 20:45

    I am sorry about the bad news, but we found out meanwhile, that the @after annotated function is only executed in the test class it belongs to. So no global implementation is possible at this point. Please abandon this patch, as it does not work out as expected. Thank you for all the effort.
  6. Mateusz Wojtuła abandoned the change 01/30/15, 20:47