36478[BUGFIX] Path of a storage must be required
Commit message
Review
-
Code review CR +2
- Philipp Gampe +2
-
Verified V +2
- Philipp Gampe +2
Issues 1
Files 2
Review log 15
-
Altan Tosun uploaded patch set 1 01/30/15, 21:01
-
Stefan Froemken commented on patch set 1 CR +1 V +1 01/30/15, 21:12
Looks good. Only one thing: With this solution I don't know if the path needs an endling slash or not. -
Ingo Schmitt voted on patch set 1 CR +1 V +1 01/30/15, 22:21
-
Frans Saris commented on patch set 1 V -1 01/30/15, 22:28
LocalDriverFlexForm.xml:14This should have a different text, something like LLL:EXT:lang/locallang_mod_file_list.xlf:localDriverFlexform_basePath_placeholder "Add path here to folder here. Make sure the folder exists." -
Altan Tosun uploaded patch set 2 01/30/15, 22:33
-
Altan Tosun uploaded patch set 3 01/30/15, 23:05
-
Philipp Gampe uploaded patch set 4 01/30/15, 23:08
-
Philipp Gampe commented on patch set 4 CR +1 V +1 01/30/15, 23:09
removed the default value -
Ingo Schmitt voted on patch set 4 CR +1 01/30/15, 23:09
-
Frans Saris uploaded patch set 5 01/30/15, 23:15
-
Frans Saris commented on patch set 5 CR +1 V +1 01/30/15, 23:15
Removed default value and adjusted the placeholder text slightly -
Philipp Gampe updated the commit message in patch set 6 01/30/15, 23:21
-
Philipp Gampe commented on patch set 6 CR +2 V +2 01/30/15, 23:22
with votes from Frans Saris -
Philipp Gampe merged patch set 6 01/30/15, 23:22
-
Philipp Gampe commented on patch set 7 01/30/15, 23:24
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 6b4028ff3abd30941797aee2b1d894d877079c84