Review main Merged

36485[BUGFIX] Deactivate output buffer for FileDumpEID.php

Roman Schürmann CR +2 V +2 Easy +3 −0 updated 01/31/15, 17:33

Commit message

If you try to download large file via FileDumpEID.php you may
get an out of memory error.

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Sebastian Fischer +1
    • Ingo Schmitt +1
  • Verified V +2
    • Philipp Gampe +2
    • Sebastian Fischer +1
    • Ingo Schmitt +1

Issues 1

Files 1

Review log 17

  1. Roman Schürmann uploaded patch set 1 01/31/15, 09:34

  2. Roman Schürmann uploaded patch set 2 01/31/15, 09:42

  3. Anja Leichsenring updated the commit message in patch set 3 01/31/15, 10:24

  4. Mathias Schreiber voted on patch set 3 CR +1 V +1 01/31/15, 11:29

  5. Oliver Klee commented on patch set 3 01/31/15, 11:42

    ResourceStorage.php:1430

    Can't we then remove the two lines above this (ob_clean and flush)?
  6. Mathias Schreiber commented on patch set 3 01/31/15, 11:43

    ResourceStorage.php:1430 Reply

    will test....
  7. Oliver Klee commented on patch set 3 01/31/15, 11:43

    This reads like the deactivated output buffer is the bug. Let's rename this to "Deactivate ...".
  8. Oliver Klee updated the commit message in patch set 4 01/31/15, 11:43

  9. Ingo Schmitt voted on patch set 4 CR +1 V +1 01/31/15, 17:20

  10. Sebastian Fischer voted on patch set 4 CR +1 V +1 01/31/15, 17:20

  11. Philipp Gampe voted on patch set 4 CR +2 V +2 01/31/15, 17:31

  12. Philipp Gampe updated the commit message in patch set 5 01/31/15, 17:32

  13. Philipp Gampe voted on patch set 5 CR +2 V +2 01/31/15, 17:33

  14. Sebastian Fischer voted on patch set 5 CR +1 V +1 01/31/15, 17:33

  15. Ingo Schmitt voted on patch set 5 CR +1 V +1 01/31/15, 17:33

  16. Philipp Gampe merged patch set 5 01/31/15, 17:33

  17. Philipp Gampe commented on patch set 6 01/31/15, 17:33

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit b979ded44ab52f442937795b72685440ab47e8be