Review main Merged

36491[BUGFIX] Improve functional test execution on Windows system

Nicole Hummel CR +2 V +2 Easy +8 −7 updated 01/31/15, 15:11

Commit message

On Windows systems you can execute several commands using '&' like
set typo3DatabaseUsername=root & set typo3DatabasePassword=root.
Unfortunately Windows sets those parameter with a trailing space. This
causes database connections not to work. Therefore the patch adds a trim
on getting system environment variables for database credentials for
functional tests.

Furthermore the PHP versions on Windows throw a warning on setting the
database name when the connection is closed. The warning is caught by
PHPUnit but the database tables aren't initialized correctly. This patch
adds an '@' to mute the warning.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Oliver Klee +1
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 1

Review log 8

  1. Nicole Hummel uploaded patch set 1 01/31/15, 11:01

  2. Steffen Müller voted on patch set 1 CR +1 01/31/15, 11:09

  3. Jan Helke voted on patch set 1 CR +1 01/31/15, 11:10

  4. Oliver Klee commented on patch set 1 01/31/15, 11:14

    Does setting the DB name still work in that case? Shouldn't we skip setting the DB instead?
  5. Oliver Klee uploaded patch set 2 01/31/15, 11:24

  6. Oliver Klee voted on patch set 2 CR +1 01/31/15, 11:25

  7. Helmut Hummel voted on patch set 2 CR +2 V +2 01/31/15, 15:11

  8. Helmut Hummel merged patch set 2 01/31/15, 15:11