Review main Merged

36493[BUGFIX] Ensure unix like paths for temp files

Nicole Hummel CR +2 V +2 Easy +1 −1 updated 01/31/15, 14:11

Commit message

Using tempnam() on Windows systems returns paths containing backslashes.
As other paths inside the core are already transformed to paths using
forward slashes some string comparisons fail. This patch ensures correct
transforming of slashes after the usage of tempnam().

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Mateusz Wojtuła +1
  • Verified V +2
    • Christian Kuhn +2
    • Oliver Klee +1

Issues 1

Files 2

Review log 13

  1. Nicole Hummel uploaded patch set 1 01/31/15, 11:18

  2. Nicole Hummel uploaded patch set 2 01/31/15, 11:19

  3. Oliver Klee commented on patch set 2 01/31/15, 11:35

    I think we should have a unit test for this that fails (on Window) without the patch and passes with it.
  4. Nicole Hummel commented on patch set 2 01/31/15, 11:37

    We have a functional test from ImpExp that fails without the patch ;-)
  5. Mateusz Wojtuła voted on patch set 2 CR +1 01/31/15, 12:09

  6. Andreas Kienast voted on patch set 2 CR +1 01/31/15, 12:29

  7. Oliver Klee commented on patch set 2 CR -1 01/31/15, 12:34

    Nicole is working on a dedicated unit test for this.
  8. Nicole Hummel uploaded patch set 3 01/31/15, 13:59

  9. Oliver Klee voted on patch set 3 V +1 CR +1 01/31/15, 14:02

  10. Mateusz Wojtuła voted on patch set 3 CR +1 01/31/15, 14:04

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 01/31/15, 14:11

  12. Christian Kuhn merged patch set 3 01/31/15, 14:11

  13. Christian Kuhn commented on patch set 4 01/31/15, 14:11

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit e411f60be284aa6a94bffb0f03849487bea5e24e