36513[CLEANUP] Make use of possible imports and remove unused ones
Commit message
Review
-
Code review CR +2
- Steffen Müller +2
- Oliver Klee +1
- Stephan Großberndt +1
-
Verified V +2
- Steffen Müller +2
- Stephan Großberndt +1
Issues 1
Files 20
- typo3/sysext/backend/Classes/ClickMenu/ClickMenu.php1+2 −2
- typo3/sysext/backend/Classes/Controller/LoginController.php+0 −1
- typo3/sysext/backend/Classes/Form/Element/SelectElement.php+0 −1
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+0 −1
- typo3/sysext/backend/Classes/Rte/AbstractRte.php+0 −2
- typo3/sysext/core/Classes/DataHandling/DataHandler.php1+0 −1
- typo3/sysext/core/Classes/TypoScript/ConfigurationForm.php+0 −1
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+0 −1
- typo3/sysext/core/Tests/Unit/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcherTest.php+1 −2
- typo3/sysext/core/Tests/Unit/Utility/ResourceUtilityTest.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php+0 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/TypolinkViewHelper.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/PaginateViewHelper.php+0 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Uri/TypolinkViewHelperTest.php+0 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Widget/Controller/PaginateControllerTest.php+0 −1
- typo3/sysext/frontend/Classes/ContentObject/Exception/ProductionExceptionHandler.php+2 −2
- typo3/sysext/frontend/Tests/Functional/Page/PageRepositoryTest.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php+0 −2
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php+0 −1
- typo3/sysext/reports/Classes/Report/Status/Status.php+0 −1
Review log 20
-
Göran Bodenschatz uploaded patch set 1 01/31/15, 15:09
-
Wouter Wolters commented on patch set 1 01/31/15, 15:12
DataHandler.php:1955Unrelated change? -
Anja Leichsenring commented on patch set 1 CR +1 V +1 01/31/15, 15:12
verified via Unit Tests -
Göran Bodenschatz commented on patch set 1 01/31/15, 15:16
@Wouter: You're right. I'm on it. -
Steffen Müller commented on patch set 1 CR -1 01/31/15, 15:18
on it, will push a fixed chageset without unrelated changes -
Göran Bodenschatz uploaded patch set 2 01/31/15, 15:20
-
Oliver Klee voted on patch set 2 CR +1 01/31/15, 15:27
-
Mateusz Wojtuła voted on patch set 2 CR +1 01/31/15, 15:27
-
Steffen Müller commented on patch set 2 CR -1 01/31/15, 15:30
Instead of removing the use statements in certain classes, rather search for Full qualified class name usage in the classes themselves. -
Göran Bodenschatz uploaded patch set 3 01/31/15, 15:47
-
Oliver Klee voted on patch set 3 CR +1 01/31/15, 15:51
-
Stephan Großberndt uploaded patch set 4 01/31/15, 16:05
-
Steffen Müller commented on patch set 4 01/31/15, 16:14
Sorry, Stephan Großberndt. The latest changeset is too big to review at once. It also creates too much workload for little use (sorting use staements alphabvetically). I'm out. -
Göran Bodenschatz uploaded patch set 5 01/31/15, 16:18
-
Steffen Müller voted on patch set 5 CR +1 V +1 01/31/15, 16:20
-
Oliver Klee voted on patch set 5 CR +1 01/31/15, 16:21
-
Stephan Großberndt commented on patch set 5 01/31/15, 16:21
Sorry, I didn't mean to block anything. But while reviewing I also thought it might be a bad time to touch all those files during code sprint. I'll do a followup when there is low traffic. -
Stephan Großberndt voted on patch set 5 V +1 CR +1 01/31/15, 16:25
-
Steffen Müller voted on patch set 5 CR +2 V +2 01/31/15, 16:27
-
Steffen Müller merged patch set 5 01/31/15, 16:27
ClickMenu.php:870