Review main Merged

36513[CLEANUP] Make use of possible imports and remove unused ones

Göran Bodenschatz CR +2 V +2 Easy +9 −26 updated 01/31/15, 16:27

Commit message

Review

  • Code review CR +2
    • Steffen Müller +2
    • Oliver Klee +1
    • Stephan Großberndt +1
  • Verified V +2
    • Steffen Müller +2
    • Stephan Großberndt +1

Issues 1

Files 20

Review log 20

  1. Göran Bodenschatz uploaded patch set 1 01/31/15, 15:09

  2. Wouter Wolters commented on patch set 1 01/31/15, 15:12

    ClickMenu.php:870

    unrelated change?

    DataHandler.php:1955

    Unrelated change?
  3. Anja Leichsenring commented on patch set 1 CR +1 V +1 01/31/15, 15:12

    verified via Unit Tests
  4. Göran Bodenschatz commented on patch set 1 01/31/15, 15:16

    @Wouter: You're right. I'm on it.
  5. Steffen Müller commented on patch set 1 CR -1 01/31/15, 15:18

    on it, will push a fixed chageset without unrelated changes
  6. Göran Bodenschatz uploaded patch set 2 01/31/15, 15:20

  7. Oliver Klee voted on patch set 2 CR +1 01/31/15, 15:27

  8. Mateusz Wojtuła voted on patch set 2 CR +1 01/31/15, 15:27

  9. Steffen Müller commented on patch set 2 CR -1 01/31/15, 15:30

    Instead of removing the use statements in certain classes, rather search for Full qualified class name usage in the classes themselves.
  10. Göran Bodenschatz uploaded patch set 3 01/31/15, 15:47

  11. Oliver Klee voted on patch set 3 CR +1 01/31/15, 15:51

  12. Stephan Großberndt uploaded patch set 4 01/31/15, 16:05

  13. Steffen Müller commented on patch set 4 01/31/15, 16:14

    Sorry, Stephan Großberndt. The latest changeset is too big to review at once. It also creates too much workload for little use (sorting use staements alphabvetically). I'm out.
  14. Göran Bodenschatz uploaded patch set 5 01/31/15, 16:18

  15. Steffen Müller voted on patch set 5 CR +1 V +1 01/31/15, 16:20

  16. Oliver Klee voted on patch set 5 CR +1 01/31/15, 16:21

  17. Stephan Großberndt commented on patch set 5 01/31/15, 16:21

    Sorry, I didn't mean to block anything. But while reviewing I also thought it might be a bad time to touch all those files during code sprint. I'll do a followup when there is low traffic.
  18. Stephan Großberndt voted on patch set 5 V +1 CR +1 01/31/15, 16:25

  19. Steffen Müller voted on patch set 5 CR +2 V +2 01/31/15, 16:27

  20. Steffen Müller merged patch set 5 01/31/15, 16:27