36518[BUGFIX] Add file_exists check to retrieveFileOrFolderObject
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 18
-
Sebastian Fischer uploaded patch set 1 01/31/15, 15:22
-
Ingo Schmitt commented on patch set 1 CR +1 V +1 01/31/15, 15:29
Cheked by Unittest -
Nicole Hummel commented on patch set 1 CR -1 01/31/15, 15:31
Could you please revoke the commit message! -
Frans Saris commented on patch set 1 01/31/15, 21:20
ResourceFactory.php:425@return FileInterface|Folder|NULL -
Frans Saris commented on patch set 1 02/01/15, 09:40
working on this -
Frans Saris uploaded patch set 2 02/01/15, 09:46
-
Frans Saris updated the commit message in patch set 3 02/01/15, 09:48
-
Frans Saris voted on patch set 3 CR +1 V +1 02/01/15, 09:49
-
Oliver Klee commented on patch set 3 V +1 CR +1 02/01/15, 10:01
Tested by running the unit tests. -
Thomas Deuling uploaded patch set 4 02/01/15, 10:22
-
Thomas Deuling commented on patch set 4 V +1 CR +1 02/01/15, 10:23
Tested by running the unit tests. -
Frans Saris commented on patch set 4 CR -1 02/01/15, 10:43
We need to check this further if the return NULL is ok. For instance on you run into a PHP fatal now instead of a exception when calling the info window for non existing files. http://master.typo3.local/typo3/show_item.php?table=_FILE&uid=uploads%2Fpics%2Ftest.jpg -
Roman Schürmann voted on patch set 4 CR +1 02/01/15, 11:38
-
Frans Saris commented on patch set 4 02/01/15, 12:52
ResourceFactory.php:425A lot places in core depend on the ResourceDoesNotExistException that gets thrown by getFolderObjectFromCombinedIdentifier() for example. We need to check all usages in core for this. Maybe a FileNotFound object could be a solution here. -
Benni Mack commented on patch set 4 CR -1 06/29/15, 19:52
agree here, this patch actually removes some nice logic with exceptions. @sebastian - how to proceed here? -
Benni Mack wrote 08/12/15, 20:39
Topic set to FAL -
Benni Mack commented on patch set 4 08/12/15, 20:40
As a file_exists should only happen in the driver, and nowhere else, I opt for abandoning this issue. Sebastian are you going to pick this topic up? Otherwise I will abandon this issue in the next few days. -
Sebastian Fischer abandoned the change 09/04/15, 06:11