Review main Merged

36522[BUGFIX] Missing stream_cast() in FileStreamWrapper

Philipp Gampe CR +2 V +2 Easy +18 −2 updated 01/31/15, 23:00

Commit message

Review

  • Code review CR +2
    • Sascha Egerer +2
    • Altan Tosun +1
  • Verified V +2
    • Sascha Egerer +2
    • Altan Tosun +1

Issues 1

Files 2

Review log 15

  1. Philipp Gampe uploaded patch set 1 01/31/15, 15:54

  2. Philipp Gampe uploaded patch set 2 01/31/15, 15:57

  3. Sascha Egerer commented on patch set 2 CR -1 01/31/15, 16:01

    FileStreamWrapperTest.php:106

    finfo is not available on every system. We should add another unit tests with outout the dependency to finfo and add a dependency for the finfo existence here. function_exists('finfo_file')
  4. Philipp Gampe uploaded patch set 3 01/31/15, 16:05

  5. Sascha Egerer commented on patch set 3 CR -1 01/31/15, 16:09

    FileStreamWrapper.php:316

    Could you add a parameter description here? Can be STREAM_CAST_FOR_SELECT when stream_select() is calling stream_cast() or STREAM_CAST_AS_STREAM when stream_cast() is called for other uses.

    FileStreamWrapperTest.php:100

    Can you please add a second tests that really tests only the method? Check if it returns false when no filestream is available and the filestream if there is one.
  6. Philipp Gampe uploaded patch set 4 01/31/15, 16:32

  7. Philipp Gampe uploaded patch set 5 01/31/15, 17:00

  8. Wouter Wolters commented on patch set 5 01/31/15, 17:06

    FileStreamWrapper.php:319

    bool
  9. Sascha Egerer commented on patch set 5 01/31/15, 17:27

    FileStreamWrapper.php:319 Reply

    Yes it must be a type. http://phpdoc.org/docs/latest/references/phpdoc/tags/return.html But you can describe that in the comment that always false is returned if no filehandle is available.
  10. Philipp Gampe uploaded patch set 6 01/31/15, 17:28

  11. Philipp Gampe commented on patch set 5 01/31/15, 17:29

    FileStreamWrapper.php:319 Reply

    Done
  12. Sascha Egerer voted on patch set 6 V +1 CR +1 01/31/15, 22:51

  13. Altan Tosun voted on patch set 6 CR +1 V +1 01/31/15, 22:59

  14. Sascha Egerer voted on patch set 6 V +2 CR +2 01/31/15, 23:00

  15. Sascha Egerer merged patch set 6 01/31/15, 23:00