36522[BUGFIX] Missing stream_cast() in FileStreamWrapper
Commit message
Review
-
Code review CR +2
- Sascha Egerer +2
- Altan Tosun +1
-
Verified V +2
- Sascha Egerer +2
- Altan Tosun +1
Issues 1
Files 2
Review log 15
-
Philipp Gampe uploaded patch set 1 01/31/15, 15:54
-
Philipp Gampe uploaded patch set 2 01/31/15, 15:57
-
Sascha Egerer commented on patch set 2 CR -1 01/31/15, 16:01
-
Philipp Gampe uploaded patch set 3 01/31/15, 16:05
-
Sascha Egerer commented on patch set 3 CR -1 01/31/15, 16:09
FileStreamWrapper.php:316Could you add a parameter description here? Can be STREAM_CAST_FOR_SELECT when stream_select() is calling stream_cast() or STREAM_CAST_AS_STREAM when stream_cast() is called for other uses.FileStreamWrapperTest.php:100Can you please add a second tests that really tests only the method? Check if it returns false when no filestream is available and the filestream if there is one. -
Philipp Gampe uploaded patch set 4 01/31/15, 16:32
-
Philipp Gampe uploaded patch set 5 01/31/15, 17:00
-
Wouter Wolters commented on patch set 5 01/31/15, 17:06
FileStreamWrapper.php:319bool -
Sascha Egerer commented on patch set 5 01/31/15, 17:27
FileStreamWrapper.php:319ReplyYes it must be a type. http://phpdoc.org/docs/latest/references/phpdoc/tags/return.html But you can describe that in the comment that always false is returned if no filehandle is available. -
Philipp Gampe uploaded patch set 6 01/31/15, 17:28
-
Philipp Gampe commented on patch set 5 01/31/15, 17:29
FileStreamWrapper.php:319ReplyDone -
Sascha Egerer voted on patch set 6 V +1 CR +1 01/31/15, 22:51
-
Altan Tosun voted on patch set 6 CR +1 V +1 01/31/15, 22:59
-
Sascha Egerer voted on patch set 6 V +2 CR +2 01/31/15, 23:00
-
Sascha Egerer merged patch set 6 01/31/15, 23:00
FileStreamWrapperTest.php:106