36527[!!!][TASK] Move xhtml_cleaning check to compatibility6
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Oliver Klee +1
- Göran Bodenschatz +1
- Christian Kuhn +1
-
Verified V +2
- Benni Mack +2
- Christian Kuhn +1
Issues 1
Files 6
- typo3/sysext/compatibility6/Classes/Hooks/TypoScriptFrontendController/ContentPostProcHook.php7new+92 −0
- typo3/sysext/compatibility6/ext_localconf.php+5 −0
- typo3/sysext/core/Classes/Html/HtmlParser.php2+3 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-62855-XHTMLCleaningMovedToLegacyExtension.rstnew+38 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php2+3 −21
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+0 −1
Review log 17
-
Jan Helke uploaded patch set 1 01/31/15, 16:28
-
Benni Mack uploaded patch set 2 01/31/15, 16:31
-
Benni Mack uploaded patch set 3 01/31/15, 16:43
-
Benni Mack voted on patch set 3 CR +1 01/31/15, 16:43
-
Oliver Klee commented on patch set 3 01/31/15, 16:46
-
Göran Bodenschatz commented on patch set 3 01/31/15, 16:55
+1 for Olivers comment -
Jan Helke uploaded patch set 4 01/31/15, 16:57
-
Oliver Klee voted on patch set 4 CR +1 01/31/15, 16:58
-
Jan Helke uploaded patch set 5 01/31/15, 17:09
-
Göran Bodenschatz voted on patch set 5 CR +1 01/31/15, 17:10
-
Oliver Klee voted on patch set 5 CR +1 01/31/15, 17:12
-
Christian Kuhn voted on patch set 5 CR +1 V +1 01/31/15, 17:15
-
Benni Mack voted on patch set 5 CR +2 V +2 01/31/15, 17:16
-
Benni Mack merged patch set 5 01/31/15, 17:16
-
Wouter Wolters commented on patch set 6 01/31/15, 17:20
post -1ContentPostProcHook.php:31wrong order here @param <type> <name>ContentPostProcHook.php:49wrong order here @param <type> <name>ContentPostProcHook.php:55=== ?ContentPostProcHook.php:67wrong order here @param <type> <name>ContentPostProcHook.php:73=== ?ContentPostProcHook.php:87=== ?HtmlParser.php:1469TYPO3 CMS 8TypoScriptFrontendController.php:3469TYPO3 CMS 8 -
Markus Klein commented on patch set 6 01/31/15, 17:38
ContentPostProcHook.php:39Short namespaces!HtmlParser.php:1445wrong function! -
Jan Helke commented on patch set 6 02/01/15, 10:37
Follow up in https://review.typo3.org/#/c/36536/
TypoScriptFrontendController.php:3242