Review main Merged Breaking

36527[!!!][TASK] Move xhtml_cleaning check to compatibility6

Jan Helke CR +2 V +2 Normal +141 −22 updated 02/01/15, 10:37

Commit message

XHTML cleaning is not neccessary anymore, after modern technology
bases completely on HTML5. Therefore the according functionality
has been moved to the legacy extension "compatibility6".

Review

  • Code review CR +2
    • Benni Mack +2
    • Oliver Klee +1
    • Göran Bodenschatz +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1

Issues 1

Files 6

Review log 17

  1. Jan Helke uploaded patch set 1 01/31/15, 16:28

  2. Benni Mack uploaded patch set 2 01/31/15, 16:31

  3. Benni Mack uploaded patch set 3 01/31/15, 16:43

  4. Benni Mack voted on patch set 3 CR +1 01/31/15, 16:43

  5. Oliver Klee commented on patch set 3 01/31/15, 16:46

    TypoScriptFrontendController.php:3242

    Should we also deprecate the method HtmlParser::XHTML_clean?
  6. Göran Bodenschatz commented on patch set 3 01/31/15, 16:55

    +1 for Olivers comment
  7. Jan Helke uploaded patch set 4 01/31/15, 16:57

  8. Oliver Klee voted on patch set 4 CR +1 01/31/15, 16:58

  9. Jan Helke uploaded patch set 5 01/31/15, 17:09

  10. Göran Bodenschatz voted on patch set 5 CR +1 01/31/15, 17:10

  11. Oliver Klee voted on patch set 5 CR +1 01/31/15, 17:12

  12. Christian Kuhn voted on patch set 5 CR +1 V +1 01/31/15, 17:15

  13. Benni Mack voted on patch set 5 CR +2 V +2 01/31/15, 17:16

  14. Benni Mack merged patch set 5 01/31/15, 17:16

  15. Wouter Wolters commented on patch set 6 01/31/15, 17:20

    post -1

    ContentPostProcHook.php:31

    wrong order here @param <type> <name>

    ContentPostProcHook.php:49

    wrong order here @param <type> <name>

    ContentPostProcHook.php:55

    === ?

    ContentPostProcHook.php:67

    wrong order here @param <type> <name>

    ContentPostProcHook.php:73

    === ?

    ContentPostProcHook.php:87

    === ?

    HtmlParser.php:1469

    TYPO3 CMS 8

    TypoScriptFrontendController.php:3469

    TYPO3 CMS 8
  16. Markus Klein commented on patch set 6 01/31/15, 17:38

    ContentPostProcHook.php:39

    Short namespaces!

    HtmlParser.php:1445

    wrong function!
  17. Jan Helke commented on patch set 6 02/01/15, 10:37