Review main Merged

36544[CLEANUP] Comments, usages and phpdoc of InlineElement

Stephan Großberndt CR +2 V +2 Normal +90 −79 updated 02/01/15, 14:49

Commit message

Clean up formatting, comments, typos, unused variables, uses and
phpdoc of TYPO3\CMS\Backend\Form\Element\InlineElement.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Oliver Klee +1
    • Göran Bodenschatz +1
    • Anja Leichsenring +1
    • Jan Helke +1
    • Benni Mack +1
  • Verified V +2
    • Nicole Hummel +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Jan Helke +1

Issues 1

Files 1

Review log 15

  1. Stephan Großberndt uploaded patch set 1 01/31/15, 21:26

  2. Oliver Klee voted on patch set 1 CR +1 01/31/15, 22:05

  3. Benni Mack commented on patch set 1 01/31/15, 23:05

    InlineElement.php:2064

    this might be a reason not to backport the patch. Might lead to unexpected behaviour on misconfigured installations.
  4. Stephan Großberndt uploaded patch set 2 01/31/15, 23:17

  5. Stephan Großberndt commented on patch set 2 01/31/15, 23:18

    Removed the array signature from checkConfiguration() so this can be backported easily. Array signatures return in TYPO3 CMS 7.5 :-)
  6. Benni Mack voted on patch set 2 CR +1 01/31/15, 23:19

  7. Oliver Klee voted on patch set 2 CR +1 01/31/15, 23:39

  8. Göran Bodenschatz voted on patch set 2 CR +1 01/31/15, 23:41

  9. Anja Leichsenring voted on patch set 2 CR +1 V +1 02/01/15, 11:41

  10. Jan Helke voted on patch set 2 CR +1 V +1 02/01/15, 12:17

  11. Oliver Klee voted on patch set 2 V +1 02/01/15, 12:20

  12. Nicole Hummel commented on patch set 2 V -1 02/01/15, 14:33

    Failing functional tests. I investigate
  13. Wouter Wolters commented on patch set 2 02/01/15, 14:34

    InlineElement.php:646

    bool
  14. Nicole Hummel commented on patch set 2 CR +2 V +2 02/01/15, 14:49

    Windows related. Second run was smooth
  15. Nicole Hummel merged patch set 2 02/01/15, 14:49