Review main Merged

36564[BUGFIX] Enhancing StripNewLinesFilter for Windows line breaks

Ronny Vorpahl CR +2 V +2 Easy +18 −2 updated 02/01/15, 12:51

Commit message

Currently the filter does not handle Windows line breaks.
This results in unfiltered Windows line breaks.
This patch adds Windows line break support to the filter function.
Furthermore the unit tests for the filter are extended to check
Windows line breaks as well.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Nicole Hummel +1
  • Verified V +2
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Nicole Hummel +1

Issues 1

Files 2

Review log 7

  1. Ronny Vorpahl uploaded patch set 1 02/01/15, 11:22

  2. Oliver Klee commented on patch set 1 V +1 CR +1 02/01/15, 12:19

    Tested by running the unit tests.
  3. Ronny Vorpahl uploaded patch set 2 02/01/15, 12:45

  4. Oliver Klee voted on patch set 2 V +1 CR +1 02/01/15, 12:48

  5. Nicole Hummel voted on patch set 2 CR +1 V +1 02/01/15, 12:50

  6. Anja Leichsenring voted on patch set 2 CR +2 V +2 02/01/15, 12:51

  7. Anja Leichsenring merged patch set 2 02/01/15, 12:51