36596[BUGFIX] foreign_selector size > 1 create new relation link is not needed
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
-
Verified V +2
- Jigal van Hemert +2
Issues 1
Files 1
Review log 14
-
Andreas Allacher uploaded patch set 1 02/02/15, 07:17
-
Andreas Allacher uploaded patch set 2 02/02/15, 07:18
-
Benni Mack wrote 02/02/15, 20:45
Topic set to FormEngine -
Göran Bodenschatz updated the commit message in patch set 3 02/02/15, 20:50
-
Andreas Allacher uploaded patch set 4 02/04/15, 10:45
-
Andreas Allacher commented on patch set 4 02/04/15, 10:46
Modified for current master. However, maybe someone should also add JS code to ensure that no element is selected for a multi-select foreign_selector. Though I never was able to get to that state, it wouldn't hurt to be sure that is the case. -
Nicole Hummel commented on patch set 4 02/10/15, 22:07
Do we need the button for foreign_selector fields at all? IMHO we have the onchange event -
Andreas Allacher commented on patch set 4 02/10/15, 22:22
On change event does not trigger, if I have e.g. a Select box of size 1 and want to select the current item. The select box always has a current item. On multi-select there can be rare cases when there is an item preselected if you reload the frame or something but there generally I never encountered it. However, I think that button is really confusing as most of the time the change event works. Maybe if there is a select of size one, there should be an empty item there and selected by default which does nothing. And for multi select it would be best to ensure there is not item selected on loading of the page. Or something similar -
Nicole Hummel commented on patch set 4 CR +1 V +1 02/15/15, 13:28
I think there isn't any preselection for a select box with size > 1 -
Mathias Schreiber voted on patch set 4 CR +1 V +1 02/15/15, 16:43
-
Göran Bodenschatz voted on patch set 4 CR +1 02/15/15, 18:25
-
Jigal van Hemert updated the commit message in patch set 5 02/15/15, 21:42
-
Jigal van Hemert commented on patch set 5 CR +2 V +2 02/15/15, 21:43
Added "releases" line to commit message; votes are still valid. -
Jigal van Hemert merged patch set 5 02/15/15, 21:43