Review main Merged

36615[TASK] Change $fixture to $subject in unit-tests

Wouter Wolters CR +2 V +2 Expert +808 −808 updated 02/02/15, 21:41

Commit message

Subject is the "system under test, the
subject you're operating on"

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Neufeind +1

Issues 1

Files 52

Show 32 more files

Review log 9

  1. Wouter Wolters uploaded patch set 1 02/02/15, 20:58

  2. Wouter Wolters uploaded patch set 2 02/02/15, 21:00

  3. Wouter Wolters commented on patch set 2 CR -1 02/02/15, 21:13

    update on its way

    DriverRegistryTest.php:33

    wrong replace
  4. Wouter Wolters uploaded patch set 3 02/02/15, 21:17

  5. Christian Kuhn voted on patch set 3 CR +2 V +2 02/02/15, 21:23

  6. Christian Kuhn commented on patch set 3 02/02/15, 21:24

    reads well, running tests is fine. should be good to go.
  7. Stefan Neufeind commented on patch set 3 V -1 CR +1 02/02/15, 21:26

    running tests
  8. Stefan Neufeind voted on patch set 3 V +1 02/02/15, 21:29

  9. Christian Kuhn merged patch set 3 02/02/15, 21:41