Review main Merged

36646[FOLLOWUP] Revamp EXT:recycler

Frederic Gaus CR +2 V +2 Easy +10 −6 updated 02/04/15, 14:08

Commit message

Fix a few coding issues in new EXT:recycler

* Remove IDE warnings
* Correct phpDoc
* Remove an unused variable
* Introduce a int typecast of GP:id
* Replace spaces with tabs

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1

Issues 1

Files 2

Review log 11

  1. Frederic Gaus uploaded patch set 1 02/04/15, 10:20

  2. Wouter Wolters voted on patch set 1 CR +1 02/04/15, 10:42

  3. Andreas Kienast uploaded patch set 2 02/04/15, 11:17

  4. Andreas Kienast voted on patch set 2 CR +1 V +1 02/04/15, 11:18

  5. Andreas Kienast updated the commit message in patch set 3 02/04/15, 11:22

  6. Andreas Kienast voted on patch set 3 CR +1 V +1 02/04/15, 11:22

  7. Wouter Wolters updated the commit message in patch set 4 02/04/15, 11:29

  8. Wouter Wolters voted on patch set 4 V +1 CR +1 02/04/15, 11:29

  9. Andreas Kienast voted on patch set 4 CR +1 V +1 02/04/15, 13:59

  10. Wouter Wolters voted on patch set 4 V +2 CR +2 02/04/15, 14:08

  11. Wouter Wolters merged patch set 4 02/04/15, 14:08