36671[BUGFIX] Ensure variable imageSizes is an array before accessing its values
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Nicole Hummel +1
- Michael Oehlhof +1
-
Verified V +2
- Christian Kuhn +2
- Nicole Hummel +1
Issues 1
Files 1
Review log 12
-
Fabien Udriot uploaded patch set 1 02/05/15, 14:08
-
Mathias Schreiber commented on patch set 1 CR +1 V +1 02/05/15, 14:13
From a technical standpoint this is a no-brainer. But I think the original intention was to make sure that neither height or width were 0, no? -
Christian Kuhn commented on patch set 1 02/05/15, 20:02
technically ok, but i'm also unsure about usages of these methods. what would happen if we throw exceptions instead to handle the issue on a different level, then? Feasible or better not? -
Fabien Udriot commented on patch set 1 02/05/15, 20:43
The class has been just introduced a week ago during the FAL sprint, so no side effect to be feared because of different return type. I would not throw an exception personally. -
Christian Kuhn commented on patch set 1 CR +1 02/05/15, 20:46
fine with me then. -
Nicole Hummel commented on patch set 1 CR -1 02/05/15, 22:14
I would prefer to handle the issue in getImageSizes() instead checking after every use. Take care of that -
Nicole Hummel uploaded patch set 2 02/05/15, 22:19
-
Nicole Hummel voted on patch set 2 CR +1 V +1 02/05/15, 22:20
-
Michael Oehlhof voted on patch set 2 CR +1 02/05/15, 22:32
-
Christian Kuhn commented on patch set 2 02/05/15, 22:45
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit a2e3624b7965afed2181f39888e4f0a5f39d831e -
Christian Kuhn voted on patch set 2 CR +2 V +2 02/05/15, 22:45
-
Christian Kuhn merged patch set 2 02/05/15, 22:46