Review main Abandoned

36678[FEATURE] Provide image dimension Metadata Extractor

Fabien Udriot CR 0 V 0 Normal +125 −0 updated 04/14/16, 15:09

Commit message

This Extractor returns the width and the height of images.
This can be convenient to restore a wrong image size or
update this info if file is updated via FTP or via the File list module.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 14

  1. Fabien Udriot uploaded patch set 1 02/05/15, 18:21

  2. Fabien Udriot commented on patch set 1 02/05/15, 18:24

    !!! This patch has a prerequisite !!! Apply https://review.typo3.org/#/c/36674/ beforehand.
  3. Fabien Udriot uploaded patch set 2 02/06/15, 15:20

  4. Frans Saris commented on patch set 2 02/06/15, 20:21

    ImageDimensionMetadataExtractor.php:81

    You need to delete the tmp files created for non Local storages. Like https://review.typo3.org/#/c/36446/3/typo3/sysext/core/Classes/Resource/Processing/LocalPreviewHelper.php
  5. Fabien Udriot uploaded patch set 3 02/07/15, 15:38

  6. Fabien Udriot commented on patch set 2 02/07/15, 15:39

    ImageDimensionMetadataExtractor.php:81 Reply

    Done
  7. Fabien Udriot commented on patch set 3 02/09/15, 07:45

    ImageDimensionMetadataExtractor.php:99

    What about moving the clean up of temporary files in the indexer class (where the extractors are called). The fact that each extractor might require a local copy, fetch the file from a remote, and delete it eventually, can cause performance problem. What if the local file is kept until the Extractors have done their job? The clean up of these local files could then happen after the last Extractor.
  8. Frederic Gaus commented on patch set 3 02/09/15, 08:55

    Just a small nitpick, will provide a new patch

    ImageDimensionMetadataExtractor.php:30

    int[]
  9. Frederic Gaus uploaded patch set 4 02/09/15, 08:56

  10. Frederic Gaus voted on patch set 4 CR +1 02/09/15, 08:57

  11. Frans Saris commented on patch set 4 CR -1 02/27/15, 07:28

    ImageDimensionMetadataExtractor.php:41

    Not sure about allowing all drivers. Problem is that when extracting metadata all extractors are called. So even if you have a special "my remote storage" width/height extractor this one is called. And it will download/copy the image for processing
  12. Frans Saris commented on patch set 4 09/30/15, 09:54

    Isn't this fixed already in a different way?
  13. Benni Mack commented on patch set 4 03/31/16, 17:12

    Fabien, I consider this solved as well directly in the Indexer->extractRequiredMetaData(). If you don't object in the next few days, I will abandon this patch. OK?
  14. Benni Mack abandoned the change 04/14/16, 15:09

    Check out EXT:extractor