36697[TASK] Apply quoteJSvalue or htmlspecialchars to getModuleUrl
Commit message
Review
-
Code review CR +2
- Alexander Opitz +2
- Jigal van Hemert +1
-
Verified V +2
- Alexander Opitz +2
- Jigal van Hemert +1
Issues 1
Files 20
- typo3/sysext/backend/Classes/ClickMenu/ClickMenu.php10+32 −5
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php2+5 −5
- typo3/sysext/backend/Classes/Controller/File/CreateFolderController.php+1 −1
- typo3/sysext/backend/Classes/Controller/File/EditFileController.php+1 −1
- typo3/sysext/backend/Classes/Controller/File/FileUploadController.php+1 −1
- typo3/sysext/backend/Classes/Controller/File/RenameFileController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/RteController.php+1 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php2+3 −3
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/PageMovingPagePositionMap.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+2 −2
- typo3/sysext/beuser/Classes/ViewHelpers/IssueCommandViewHelper.php+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/RemoveUserViewHelper.php+1 −1
- typo3/sysext/core/Classes/Database/QueryView.php+2 −2
- typo3/sysext/filelist/Classes/FileList.php+1 −1
- typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php+2 −2
- typo3/sysext/sys_note/Classes/ViewHelpers/DeleteLinkViewHelper.php+2 −2
- typo3/sysext/version/Classes/Controller/VersionModuleController.php+1 −1
Review log 24
-
Wouter Wolters uploaded patch set 1 02/05/15, 22:36
-
Michael Oehlhof voted on patch set 1 CR +1 02/05/15, 22:59
-
Helmut Hummel commented on patch set 1 V -1 02/06/15, 08:15
Tests fail: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/49670614 There seems to be a PHP syntax error in typo3/sysext/backend/Classes/ClickMenu/ClickMenu.php on line 1021 -
Wouter Wolters commented on patch set 1 02/06/15, 08:16
ClickMenu.php:1021hereClickMenu.php:1135space missing -
Wouter Wolters uploaded patch set 2 02/06/15, 08:22
-
Michael Oehlhof commented on patch set 2 CR +1 02/06/15, 09:09
I've overlook these mistakes while doing code review in gerrit. I'll better do it in PHPStorm next time. -
Alexander Opitz commented on patch set 2 CR -1 02/06/15, 12:51
Only checked first file, maybe I do not understand it correctly, but it looks wrong.ClickMenu.php:730Beside that the code is hard to understand, we have 3 different forms to build $editOnClick at $this->frameLocation (beside the fact I don't understand the double braces): (($loc . '.document')) . '.search)+' . GeneralUtility::quoteJSvalue('& No escaped ' concatenated with quoteJSvalueClickMenu.php:801(($loc . '.document')) . '.search)+\'' . '& With an escaped ' Concatenated without quoteClickMenu.php:1021(($loc . '.document')) . '.search)+\'' . '& With an escaped ' Concatenated without quoteClickMenu.php:1120(($loc . '.document')) . '.search)+"' . '& With " Concatenated without quoteClickMenu.php:1135(($loc . '.document')) . '.search)+"' . '& With " Concatenated without quote -
Wouter Wolters commented on patch set 2 02/06/15, 17:24
Sorry Alexander I don't get your remarks... -
Jigal van Hemert commented on patch set 2 CR -1 V -1 02/07/15, 16:52
Found a number of problems (missing quoteJSvalue() calls, wrong strings passed to quoteJSvalue()) and the lines are way too long in a number of places. Only commented a few, will change the rest directly. Will push a new set after going through all the changes in this patch.ClickMenu.php:730ReplyPartly correct. Hard to read, quoteJSvalue() does add quotes and the double braces are unnecessary.ClickMenu.php:801ReplyPlus a missing quoteJSvalue() -
Jigal van Hemert uploaded patch set 3 02/07/15, 19:00
-
Jigal van Hemert voted on patch set 3 CR +1 V +1 02/07/15, 19:05
-
Andreas Kienast uploaded patch set 4 02/08/15, 09:53
-
Andreas Kienast voted on patch set 4 CR +1 V +1 02/08/15, 09:55
-
Michael Oehlhof commented on patch set 4 02/08/15, 14:17
PageLayoutController.php:481Is cmdd correct or a typo? -
Andreas Kienast commented on patch set 4 CR -1 02/08/15, 14:23
PageLayoutController.php:481ReplyGood catch, I'm on it -
Andreas Kienast uploaded patch set 5 02/08/15, 14:27
-
Jigal van Hemert commented on patch set 5 CR -1 02/08/15, 16:47
Please don't include styling changes here. This patch only corrects the encoding of the new links and URLs.Clipboard.php:373This not related to the issue of this patch. Please move styling changes to a separate patch. -
Andreas Kienast commented on patch set 5 02/08/15, 17:12
Clipboard.php:373ReplyThis change is in master and was actually causing the conflict. -
Jigal van Hemert commented on patch set 5 CR +1 V +1 02/08/15, 17:31
> (1 comment) Oops! Sorry! That happens if I review without syncing first <facepalm> -
Alexander Opitz commented on patch set 5 CR -1 02/09/15, 10:34
I'm on review atm ... will take a while.ClickMenu.php:808Double open/close brackets? 18 times in the source. -
Wouter Wolters commented on patch set 5 02/09/15, 10:44
Guys this is not about resolving all places where single quotes are used with a backslash!!!! Please only review the needed changes for getModuleUrl. THANKS! -
Alexander Opitz commented on patch set 5 CR +1 02/09/15, 11:46
All in all it doesn't look nice but sufficient for this issue. -
Alexander Opitz voted on patch set 5 V +2 CR +2 02/10/15, 08:35
-
Alexander Opitz merged patch set 5 02/10/15, 08:35